Merge lp://staging/~gary/launchpad/bug724025 into lp://staging/launchpad

Proposed by Gary Poster
Status: Merged
Approved by: Gary Poster
Approved revision: no longer in the source branch.
Merged at revision: 13820
Proposed branch: lp://staging/~gary/launchpad/bug724025
Merge into: lp://staging/launchpad
Diff against target: 107 lines (+59/-6)
3 files modified
lib/lp/bugs/browser/bugtask.py (+12/-4)
lib/lp/bugs/browser/tests/test_bugtask.py (+45/-0)
lib/lp/bugs/model/bug.py (+2/-2)
To merge this branch: bzr merge lp://staging/~gary/launchpad/bug724025
Reviewer Review Type Date Requested Status
Robert Collins (community) Approve
Review via email: mp+72776@code.staging.launchpad.net

Commit message

[incr] [r=lifeless][bug=724025] Reduce queries when you have several branches for a bug.

Description of the change

This branch fixes some low-hanging fruit when you have several branches: significantly reduce the queries in this case. More could be done, but I'm about to move on.

lint is happy.

Thank you

To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote :

I'm a little uncomfortable with the orthogonal comments about storm cache size - this is a pattern we're using all over the place; if we need to up the storm cache size in dev to match prod, lets just do that. This isn't really an actionable review comment, of course.

review: Approve
Revision history for this message
Gary Poster (gary) wrote :

+1 on upping the storm cache on dev, at least to 1000 or so. dev is 100 right now, prod is 10000. I'll make a separate branch for that.

Thanks

Revision history for this message
Gary Poster (gary) wrote :

I had to revert this because the branch on which it relied was reverted. Resubmitting after reinstating.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.