Merge lp://staging/~gary/launchpad/bug723999-2a into lp://staging/launchpad
Status: | Merged |
---|---|
Merged at revision: | 12548 |
Proposed branch: | lp://staging/~gary/launchpad/bug723999-2a |
Merge into: | lp://staging/launchpad |
Diff against target: |
472 lines (+106/-99) 3 files modified
lib/lp/bugs/interfaces/structuralsubscription.py (+0/-8) lib/lp/bugs/model/structuralsubscription.py (+39/-27) lib/lp/bugs/tests/test_structuralsubscriptiontarget.py (+67/-64) |
To merge this branch: | bzr merge lp://staging/~gary/launchpad/bug723999-2a |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Benji York (community) | code | Approve | |
Review via email:
|
Description of the change
This MP is one of several I'll be making to clean up my work on bug723999. I'm dividing up the work to try and make it easier to review.
This branch is about removing the getSubscription
I replace it with the get_structural_
I adapted the tests to use the new function. Unfortunately, they are in the wrong module, because this code no longer has anything to do with targets directly. I will move the tests to test_structural
make lint is happy.
Thank you
Gary
This branch looks fine, being primarily a mechanical transformation from one perspective to another.