Merge lp://staging/~gary/launchpad/bug713382 into lp://staging/launchpad
Status: | Merged |
---|---|
Approved by: | Curtis Hovey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12361 |
Proposed branch: | lp://staging/~gary/launchpad/bug713382 |
Merge into: | lp://staging/launchpad |
Diff against target: |
51 lines (+26/-1) 2 files modified
lib/lp/bugs/model/bug.py (+12/-1) lib/lp/bugs/tests/test_bugchanges.py (+14/-0) |
To merge this branch: | bzr merge lp://staging/~gary/launchpad/bug713382 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
j.c.sackett (community) | code* | Approve | |
Review via email: mp+49145@code.staging.launchpad.net |
Commit message
[r=jcsackett,
Description of the change
This branch fixes the linked bug with a test (from Danilo) and a simple fix. The use of the temporary recipients object is a bit odd and ugly, but we want to know why the recipients were added, which is the point of the recipients collection, but we don't know yet if we can add them. Therefore, I did what I did.
make lint is happy.
Run the test with "./bin/test -vvt test_no_
To QA, log in as a user that has malone.
Thank you
Gary
This looks good to me. You're right that it's a little awkward, but it does seem like the best solution.