Merge lp://staging/~gary/launchpad/bug711362 into lp://staging/launchpad/db-devel
Proposed by
Gary Poster
| Status: | Merged |
|---|---|
| Merged at revision: | 10166 |
| Proposed branch: | lp://staging/~gary/launchpad/bug711362 |
| Merge into: | lp://staging/launchpad/db-devel |
| Prerequisite: | lp://staging/~gary/launchpad/move-bugnotificationlevel-enum |
| Diff against target: |
108 lines (+51/-4) 3 files modified
lib/lp/bugs/interfaces/structuralsubscription.py (+5/-0) lib/lp/bugs/model/structuralsubscription.py (+7/-4) lib/lp/bugs/tests/test_structuralsubscription.py (+39/-0) |
| To merge this branch: | bzr merge lp://staging/~gary/launchpad/bug711362 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Leonard Richardson (community) | Approve | ||
|
Review via email:
|
|||
Commit message
[r=leonardr]
Description of the change
This branch addresses the linked bug. It was not possible to delete structural subscriptions if they had filters, because the deletion would not cascade. This now cascades the delete.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This is a good improvement; the only problem is a confusing comment in the test on line 90. We discussed alternate wording on IRC.