Merge lp://staging/~gary/launchpad/bug548-db-cleanup into lp://staging/launchpad
Proposed by
Gary Poster
| Status: | Merged |
|---|---|
| Approved by: | Gary Poster |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 12340 |
| Proposed branch: | lp://staging/~gary/launchpad/bug548-db-cleanup |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
657 lines (+199/-220) 6 files modified
lib/lp/bugs/doc/bug-set-status.txt (+48/-68) lib/lp/bugs/doc/externalbugtracker-comment-imports.txt (+35/-51) lib/lp/bugs/doc/externalbugtracker-trac-lp-plugin.txt (+39/-49) lib/lp/bugs/tests/bugs-emailinterface.txt (+35/-49) lib/lp/testing/dbuser.py (+2/-3) lib/lp/testing/tests/test_dbuser.py (+40/-0) |
| To merge this branch: | bzr merge lp://staging/~gary/launchpad/bug548-db-cleanup |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Graham Binns (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
[r=gmb][no-qa] test, tweak, and exercise the dbuser test helper
Description of the change
This branch tests, tweaks, and exercises a test helper I added in the course of working on bug548, dbuser (and the convenience lp_dbuser).
The test helper is a push-pop helper for a pattern found throughout our tests. It's simple, but lets us remove some code and, IMO, looks nicer too, since it essentially puts setup code in with blocks.
To post a comment you must log in.
Revision history for this message
| Gary Poster (gary) wrote | # |
Revision history for this message
| Graham Binns (gmb) | # |
review:
Approve
(code)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Note that the SQL file does not have anything to do with this branch. It will be merged into devel before PQM is reopened.