Merge lp://staging/~gary/launchpad/bug403618 into lp://staging/launchpad
Proposed by
Gary Poster
| Status: | Merged |
|---|---|
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~gary/launchpad/bug403618 |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
13 lines (+2/-1) 1 file modified
lib/canonical/launchpad/zcml/librarian.zcml (+2/-1) |
| To merge this branch: | bzr merge lp://staging/~gary/launchpad/bug403618 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Guilherme Salgado (community) | Approve | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Gary Poster (gary) wrote | # |
Revision history for this message
| Guilherme Salgado (salgado) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This branch fixes a misconfiguration discussed in bug 403618. It does not add a test because the example shown in the bug report does not duplicate the problem, because the problem is an extreme edge case, and, generally, because I believe the cost of writing the test would be much higher than the benefit, and I've gotten salgado and flacoste to agree. :-)
The branch passed ec2 already.