Merge lp://staging/~gary/launchpad/bug-772763-remove-unmute-dialog into lp://staging/launchpad/db-devel
| Status: | Merged |
|---|---|
| Approved by: | Brad Crittenden |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 10583 |
| Proposed branch: | lp://staging/~gary/launchpad/bug-772763-remove-unmute-dialog |
| Merge into: | lp://staging/launchpad/db-devel |
| Prerequisite: | lp://staging/~danilo/launchpad/bug-772763-remove-unmute-dialog |
| Diff against target: |
28 lines (+8/-7) 1 file modified
lib/lp/bugs/javascript/bugtask_index_portlets.js (+8/-7) |
| To merge this branch: | bzr merge lp://staging/~gary/launchpad/bug-772763-remove-unmute-dialog |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brad Crittenden (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
[r=bac][bug=772763] Include JS to be able to unmute without a dialog, simply restoring the previous subscription.
Description of the change
This branch addresses the review comments from https:/
I added a green flash to any newly added item in the subscriber list because it made this particular case look better balanced (since muting also uses a green flash on the muted subscriber) and because I thought it was generally appropriate for our UI patterns.
Thank you
Gary
Thanks for the fix and explanation Gary.