lp://staging/~gary/juju-gui/styling-environment-menu
- Get this branch:
- bzr branch lp://staging/~gary/juju-gui/styling-environment-menu
Branch merges
- Juju GUI Hackers: Pending requested
-
Diff: 208 lines (+55/-34)2 files modifiedapp/views/topology/service.js (+28/-11)
lib/views/stylesheet.less (+27/-23)
Branch information
Recent revisions
- 873. By Gary Poster
-
Tweak CSS for OSCON
This branch has three visual fixes. Two of them are supposed to last, and the other is throw-away.
- GOOD: commits were not pluralizing correctly. This is because they were strings, not ints. I changed the code to send ints.
- GOOD: on the charm token, the download and commit line was not floating propoerly for some charms because the line was getting too long. I tweaked the CSS to force a width, with ellipses.
- THROW-AWAY: in the old, old charm page, the page was no longer scrollable. I added code to set the height as we have done on other pages. This should actually destroy subscriptions and do other nice clean up things, but this page will be destroyed as soon as we get the inspector.R=jeff.pihach, benji
CC=
https://codereview. appspot. com/11593043 - 872. By Richard Harding
-
Move inspector code to own module. No func change
- Move the inspector view related code to a new views/inspector.js
- A couple of objects are used in both service.js and inspector.js so they're
attached to the namespace and shared.
- Updated tests to pull in required modules to pass.
- A few small nit-picks, ordering of imports, var names, etc.R=gary.poster, jeff.pihach
CC=
https://codereview. appspot. com/11579043 - 871. By Jeff Pihach
-
Unit details wrapper refactoring
Fixed a couple view container and databinding bugs.
Wrote tests to avoid any further regressions.R=bac, matthew.scott
CC=
https://codereview. appspot. com/11574043 - 870. By Gary Poster
-
Merge antdillon's inspector styling branch
R=j.c.sackett
CC=
https://codereview. appspot. com/11532044 - 869. By j.c.sackett
-
Quick fix for service config missing error.
R=gary.poster
CC=
https://codereview. appspot. com/11544044 - 868. By Madison Scott-Clary
-
Docs update for viewlets.
Docs now discuss viewlets defined in other files.
R=rharding, benjamin.saller
CC=
https://codereview. appspot. com/11543043 - 867. By Jeff Pihach
-
Unit list overview fixes
User friendly header labels
Sorting headers
Fixed height calculation bugR=matthew.scott
CC=
https://codereview. appspot. com/11525044 - 866. By Huw Wilkins
-
Fix presentation issues in IE10
FIXES:
- Charm details last tabs wrapping onto new line.
- Charmtoken icons stretching on screen - they are new clipped in some cases,
but this also solves issues with additional scrollbars appearing.R=gary.poster
CC=
https://codereview. appspot. com/11431043
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://staging/juju-gui/experimental