lp://staging/~gary/juju-gui/process

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/juju-gui/experimental at revision 218

Juju GUI Hackers: Pending requested 2012-11-01

Diff: 104 lines (+71/-12)

1 file modified

docs/process.rst (+71/-12)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

218. By Gary Poster on 2012-11-01

Add checklists for coding and reviewing

217. By Gary Poster on 2012-10-31

'make server' should not always run yuidoc

I discovered that 'make server' always ran yuidoc. This was because, in part, the automatically generated FILES list included inappropriate files. There is another factor that affects this that I did not identify, but fixing the first problem is sufficient.

Fixing the problem specified the JS files more tightly, which revealed a few more lint changes.

I did a fly-by in the README.

R=
CC=
https://codereview.appspot.com/6823057

216. By Thiago Veronezi on 2012-10-31

Automatic sprite image generation

The Makefile will automatically generate the sprite png and css
files during the "make server" call for all the images under the
"app/assets/images" folder.

R=gary.poster
CC=
https://codereview.appspot.com/6811050

215. By Francesco Banconi on 2012-10-30

Documentation for secure websocket connections.

R=benjamin.saller
CC=
https://codereview.appspot.com/6761054

214. By Benji York on 2012-10-29

The yuidoc rule also depends the node modules.

R=
CC=
https://codereview.appspot.com/6822047

213. By Benji York on 2012-10-29

Add yuidoc linter.

In an attempt to not introduce reams of lint straight off, there is a file
named "undocumented" that includes the currently undocumented functions. Once
a function is documented it should be removed from that file (and the script
will complain if it is not).

R=gary.poster, benji.york
CC=
https://codereview.appspot.com/6820047

212. By Nicola Larosa on 2012-10-29

Reformat the README file.

Reformat the README file as proper ReST markup, so that my head does
not hurt every time I read it. With a few spelling and style fixes.

R=gary.poster
CC=
https://codereview.appspot.com/6814049

211. By Benji York on 2012-10-29

Stop sending the app object to views.

This refactoring is intended to flatten the namespace views use and make the
values available to views both more constrained and better specified.

R=hazmat
CC=
https://codereview.appspot.com/6735048

210. By Brad Crittenden on 2012-10-29

Further refinements to charm config panel.

* Change config file input widget from native HTML5 widget to an image
  overlay.

* Replace deploy and cancel buttons with CSS. They don't exactly
  match the visual design but that will come in the next branch.

* Set charm panel background. There is a problem in that it doesn't
  go to the bottom but Gary's branch will fix it.

R=
CC=
https://codereview.appspot.com/6774051

209. By Benji York on 2012-10-29

Enable yuidoc and add a start to docs.

We now install yuidoc and generate docs as part of "make install". Similarly
this branch makes "make install" stop doing a "make test" as discussed
previously.

R=
CC=
https://codereview.appspot.com/6783049