lp://staging/~gary/juju-gui/nodeChangeHandler

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/juju-gui/experimental at revision 1027

Juju GUI Hackers: Pending requested 2013-09-11

Diff: 282 lines (+93/-51)

5 files modified

app/views/databinding.js (+40/-12)
app/views/inspector.js (+1/-1)
test/test_databinding.js (+49/-35)
test/test_inspector_constraints.js (+1/-1)
test/test_inspector_settings.js (+2/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1030. By Gary Poster on 2013-09-11

clean up unused argument

1029. By Gary Poster on 2013-09-11

factor out _nodeChanged from _nodeChangeHandler to make it a bit easier to call the functionality without a (mock) event.

1028. By Gary Poster on 2013-09-10

factor out _getBinding for tests and readability

1027. By Gary Poster on 2013-09-10

change _storeChanged to _nodeChangeHandler

1026. By Gary Poster on 2013-09-10

hide and show save controls

In the inspector, controls to save values are hidden when there are no changes, and revealed when there are. Changes can come from saving the form or from simply manually reverting values.

This also changes the "modified" asterisk to be removed when the user manually reverts values.

R=benjamin.saller
CC=
https://codereview.appspot.com/13368051

1025. By Gary Poster on 2013-09-09

highlight saved input fields

This highlights saved input fields with a quick green background animation.

R=rharding
CC=
https://codereview.appspot.com/13477044

1024. By Gary Poster on 2013-09-09

Fix inspector constraints save button

The inspector constraints tab had an odd bug: if you created a service and then looked at the inspector, opened the constraints tab, made a change, and clicked "Confirm," the button would save but then change the text to "Save Changes". After verifying with Luca the intended behavior was to have a "Confirm" text, this branch makes the button stay as is.

R=benji
CC=
https://codereview.appspot.com/13621043

1023. By Gary Poster on 2013-09-09

improve databinding changedValues accuracy

- more accurately keep track of changed values
- switch changedValues to being an Object
- Make changedValues public
- added eq to databinding fields

R=rharding, benji
CC=
https://codereview.appspot.com/13385045

1022. By j.c.sackett on 2013-09-06

Removes filters from search

-Removes filter widget from search views
-Removes show/hide logic
-Removes defaults from filter model
-Adds search organization search view
-Tests

R=rharding
CC=
https://codereview.appspot.com/13289046

1021. By Richard Harding on 2013-09-06

Update charm token per ux.

- Update to show series
- Update to show owner if not reviewed, else show 'recommended'
- Remove description
- change commits/downloads to "Deployed XX times"
- Updated to appear cleanly on the fullscreen reviewed charms view, but the
data is not in the api currently so it shows up incomplete.

To QA:

Load the gui and look through the sidebar, make sure to look down in the new
charms to view non-recommended charms, etc.

Do searches and make sure the tokens show correctly and you can distinguish
between different charms in the results.

Load a single charm in fullscreen mode and note how the related charms don't
have the series/owner info because that info is not in the charm /related api.

e.g.

/fullscreen/precise/mysql-10

R=j.c.sackett
CC=
https://codereview.appspot.com/13239049