lp://staging/~gary/juju-gui/inspector-visual-review-bugs

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/juju-gui/experimental at revision 1058

Juju GUI Hackers: Pending requested 2013-09-18

Diff: 283 lines (+34/-49)

9 files modified

app/templates/ghost-config-viewlet.handlebars (+4/-4)
app/templates/inspector-header.handlebars (+3/-1)
app/templates/service-configuration.handlebars (+3/-1)
app/templates/service-configuration.partial (+0/-6)
app/templates/service-expose.partial (+3/-3)
app/views/ghost-inspector.js (+2/-7)
app/views/inspector.js (+2/-2)
lib/views/juju-inspector.less (+15/-23)
test/test_ghost_inspector.js (+2/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1059. By Gary Poster on 2013-09-18

address concern from Huw

1058. By Gary Poster on 2013-09-18

merge branch from Huw

1057. By Gary Poster on 2013-09-17

Use green checkmark for save indicator

It fades in chrome, and merely turns off after a second in FF (and hopefully IE10).

R=benji
CC=
https://codereview.appspot.com/13747043

1056. By Benji York on 2013-09-17

Add charmworld v3 API support.

The v2 API was changed to be a subclass of v3 so that removing v2 when it is
retired will be easy. There is a feature flag to enable the v3 API.

R=gary.poster
CC=
https://codereview.appspot.com/13368056

1055. By Benji York on 2013-09-17

Polish up the Charmwold API v2

This branch is another step toward adding v3 support. The whole branch was
too big so this branch was split out as an intermediary.

R=gary.poster
CC=
https://codereview.appspot.com/13627048

1054. By Richard Harding on 2013-09-17

Quick hack to CI to clear autocomplete window.

R=
CC=
https://codereview.appspot.com/13662044

1053. By Gary Poster on 2013-09-17

Sync relation menu with inspector open and close

While the relation menu is going away soonish, if the plans are to be believed, meanwhile it is what we have. This branch makes it so that when the inspector is first opened--after a ghost or when you click on a service--the relation menu appears. Similarly, when you close the inspector, relation menus close.

It is still possible to hide the relation menu while the inspector is open. If you begin to create a relation, the option will disappear; and if you click the canvas it will disappear. These seem like pretty good interactions for me, given the fundamental oddity (to me) of having the relation menu and the inspector separate entities, at least given the current design.

R=matthew.scott
CC=
https://codereview.appspot.com/13583044

1052. By Richard Harding on 2013-09-17

Rename BrowserCharm model to just Charm

- This is the last bit of unifying the charm models.
- Mechanical change of BrowserCharm to Charm for model/model list.

QA
---

Try to hit things that load the model. Most things should be a matter of tests
passing, but a quick qa through

- browser
- performing a search
- deploying the charm
- opening the details view from the inspector

R=gary.poster, bac
CC=
https://codereview.appspot.com/13273047

1051. By Richard Harding on 2013-09-17

Round 1 of small UX bug squashing per Luca

The chevrons seem to all be facing in the wrong direction. Chevrons should
point in the direction of the action, for example, a chevron should point down
to show that when clicked it will expand down, once clicked it should point up
to show that when clicked it will collapse the listing.

"Use the default configuration?" should be "Use default configuration?" and
there should be no true or false.

When you scale up and the "Scale up with the following constraints?" dialogue
appears it says "Edit this" it should say "Edit"

"XX Running" should read "XX running units"

"XX Pending" should read "XX pending units"

"XX Needs reboot" should read "XX machine need to be restarted"

"XX Security upgrade" should read "XX security upgrades available"

Can we change "Cancel" in the save dialogue to "Discard changes"

R=gary.poster
CC=
https://codereview.appspot.com/13467049

1050. By Gary Poster on 2013-09-17

Inspector shows up after ghost inspector

- Per UX, after ghost inspector finishes, real inspector starts
- Changed new service creation to not bounce the box around
- Made a couple of other small tweaks for sandbox edge cases and capitalization

R=matthew.scott
CC=
https://codereview.appspot.com/13246050