lp://staging/~gary/juju-gui/fix_sourcemap
- Get this branch:
- bzr branch lp://staging/~gary/juju-gui/fix_sourcemap
Branch merges
- Juju GUI Hackers: Pending requested
-
Diff: 14 lines (+2/-2)1 file modifiedMakefile (+2/-2)
Branch information
Recent revisions
- 1138. By Richard Harding
-
Styled new header and notifications.
As per the new mockups here:
https://docs.google. com/a/canonical .com/file/ d/0B9WMKNMU_ KomMWUtUWdfVGR1 WVk/edit? usp=drive_ web - 1137. By Gary Poster
-
Subordinate service should not export num_units
Fix for deployer output.
R=frankban
CC=
https://codereview. appspot. com/14725044 - 1136. By Benjamin Saller
-
Redo Service Placement
This changes a number of aspects of how service placement is handled. There
may still be some edge cases and QA will need to be extensive as this
has moved through phases where various parts worked and didn't. I believe
this version to be good however.Position annotations remain on service models now rather than being deleted
when applied. We favor this to having vars such as hasBeenPositioned,
positionedFromGhost and service model x/y (which mixed into BoundingBoxes).
These various complications are mostly gone and the handling of updating
position annotations falls to a single method on the topology. (Though to be
fair that is still called from more than one place).Further simplification might be possible by unifying the node creation and
node update paths wrt annotations. This didn't however fit in the time
provided.This also includes a basic fix for always pulling positions from the client
during an export.R=gary.poster, benjamin.saller, matthew.scott
CC=
https://codereview. appspot. com/14695043 - 1135. By Gary Poster
-
Change text
A flyby fix for trivial bug while looking at backlog. self-reviewing.
- 1134. By Gary Poster
-
Produce xz distribution tarballs
Per https:/
/codereview. appspot. com/14425057 , change the GUI to produce xz files. See the QA in the other proposal. R=bac
CC=
https://codereview. appspot. com/14494056 - 1133. By Gary Poster
-
Change distfile to exclude unnecessary bits
In order to address the charm deployment problems reported today, this is a first step of two that significantly shrinks the size of our releases. It takes our release down from about 43M to 9M; that brings our charm from about 45M to 11M. I'll make another step (switch from gz to xz) that can bring us down another couple of M. Hopefully that will be sufficient for the problem.
The code is pretty easy to review, but the qa is a bit more tedious. First, please make a distfile (BRANCH_IS_GOOD=1 make distfile) and then follow the instructions I added to the release instructions to test the resulting tarball. Second, add the tarball to a local copy of the charm in the releases directory, remove the 0.10.1 tarball, juju bootstrap, and run make deploy in the charm. Once the charm is deployed, you should be able to see qa the site.
R=frankban
CC=
https://codereview. appspot. com/14516054 - 1132. By Jeff Pihach
-
Bundle topology rendering fails gracefully
If the bundle does not provide proper xy position annotations
on any of the services in its deployer file we do not render
the bundle topology and instead remove the bundle topology
tab, selecting the Charms tab to show the charms the
bundle contains.Because we don't have any bundles with proper positions right
now I added the flag `strictBundle` to enable this feature.R=gary.poster
CC=
https://codereview. appspot. com/14502061 - 1131. By Jeff Pihach
-
Deploy bundles from the bundle detail view
Clicking the 'Deploy' button from the bundle detail view
now deploys the bundle. Also added notifications for this
button and for drag and drop bundle deployment.R=gary.poster
CC=
https://codereview. appspot. com/14419062 - 1130. By Gary Poster
-
After units are deployed, re-enable unit control
R=jeff.pihach
CC=
https://codereview. appspot. com/14512056
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://staging/juju-gui/experimental