lp://staging/~gary/juju-gui/fixDeltaFromChangeEdgeCase

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/juju-gui/experimental at revision 1030

Juju GUI Hackers: Pending requested 2013-09-11

Diff: 169 lines (+69/-29)

2 files modified

app/views/databinding.js (+57/-29)
test/test_databinding.js (+12/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1032. By Gary Poster on 2013-09-11

merge trunk

1031. By Gary Poster on 2013-09-11

optimize deltaFromChange and fix an edge case in it; and add docs about bindings.

1030. By Gary Poster on 2013-09-11

micro-optimization: do not repeat binding initialization unnecessarily.

1029. By Gary Poster on 2013-09-11

merge trunk

1028. By Gary Poster on 2013-09-11

fix conflict resolution logic

1027. By Gary Poster on 2013-09-11

Refactor and rename BindingEngine._storeChanged

This is a small clean-up branch in preparation to cleaning up some of the conflict resolution edge cases. It is largely about refactoring and renaming BindingEngine._storeChanged.

* BindingEngine._storeChanged is now called _nodeChangeHandler.
* That method simply calls out to the new method _nodeChanged. It takes a node rather than an event with a node.
* Factored _getBinding out of _nodeChanged to make the code read better and to test the functionality independently.
* Adjusted tests to use _nodeChanged.
* Refactored tests to reuse more code and clean up some lint.
* Added tests for _getBinding.

In addition to those related changes, I made one more peripheral change: I removed an unused argument to unsyncedFields.

R=benjamin.saller
CC=
https://codereview.appspot.com/13265045

1026. By Gary Poster on 2013-09-10

hide and show save controls

In the inspector, controls to save values are hidden when there are no changes, and revealed when there are. Changes can come from saving the form or from simply manually reverting values.

This also changes the "modified" asterisk to be removed when the user manually reverts values.

R=benjamin.saller
CC=
https://codereview.appspot.com/13368051

1025. By Gary Poster on 2013-09-09

highlight saved input fields

This highlights saved input fields with a quick green background animation.

R=rharding
CC=
https://codereview.appspot.com/13477044

1024. By Gary Poster on 2013-09-09

Fix inspector constraints save button

The inspector constraints tab had an odd bug: if you created a service and then looked at the inspector, opened the constraints tab, made a change, and clicked "Confirm," the button would save but then change the text to "Save Changes". After verifying with Luca the intended behavior was to have a "Confirm" text, this branch makes the button stay as is.

R=benji
CC=
https://codereview.appspot.com/13621043

1023. By Gary Poster on 2013-09-09

improve databinding changedValues accuracy

- more accurately keep track of changed values
- switch changedValues to being an Object
- Make changedValues public
- added eq to databinding fields

R=rharding, benji
CC=
https://codereview.appspot.com/13385045