lp://staging/~gary/juju-gui/fix-charm-panel-tests

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/juju-gui/experimental at revision 735

Juju GUI Hackers: Pending requested 2013-06-14

Diff: 123 lines (+51/-19)

5 files modified

app/subapps/browser/templates/browser_charm.handlebars (+3/-0)
app/subapps/browser/templates/sidebar.handlebars (+3/-0)
app/templates/browser-search.handlebars (+3/-0)
app/templates/charm-token.handlebars (+3/-0)
test/test_charm_running.py (+39/-19)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

735. By Gary Poster on 2013-06-14

respond to review

734. By Gary Poster on 2013-06-14

actually search for the desired charm

733. By Gary Poster on 2013-06-14

merge in CI fix work from Jeff with some changes per unofficial review by myself and Rick.

732. By Jeff Pihach on 2013-06-13

Dark header style change

Commiting Huw's markup and style changes for the header
I also changed the styles for the right configuration
panel to better blend with the new header.
I also put a bandaid on the right configuration panel
height issue, it doesn't recalculate on resize, and it's
a 'magic number' fix.

R=gary.poster
CC=
https://codereview.appspot.com/10241046

731. By Richard Harding on 2013-06-13

Fixes #1190653 properly ignore /login as charmid

- The /login/ url was getting two matches to the regex used to detect if this
was a charmid or just a /something string that should be ignored. It was
matching login/ and n/.
- Rather than a regex, actually remove the start/trail '/' and split on any
other /. If there's exactly two parts then this is a charmid we should try to
match and display.

R=curtis, jeff.pihach
CC=
https://codereview.appspot.com/10253049

730. By Jeff Pihach on 2013-06-13

Removal of right charm search panel

This branch is the first step towards removing the right panel
entirely. All deployments are now done via the charm browser
and only ghost configuration is done by the right panel.

R=gary.poster, matthew.scott
CC=
https://codereview.appspot.com/10241043

729. By Richard Harding on 2013-06-13

Fixes #1190265 move config to config.options

- It appears at some point the Charm model moved the yaml config from a pure
config ATTR to a config.options.
- This nests our config in the BrowserCharm when adding a charm to the
environment.

R=jeff.pihach, gary.poster
CC=
https://codereview.appspot.com/10246044

728. By Benji York on 2013-06-13

[r=matsubara][bug=][author=benji] The beginings of a Go-flavored sandbox.

Logging in, deploying a service, and moving it around all work.

727. By Nicola Larosa on 2013-06-12

A cookies warning handler, enabled by analytics.

When "useAnalytics" is set to "true", we use a cookie to record user
agreement to the usage of cookies. :-)

A banner will be displayed asking for cookie usage agreement,
and the cookie will be set on user dismissal of said banner.

R=jeff.pihach, bac
CC=
https://codereview.appspot.com/9967044

726. By Richard Harding on 2013-06-12

Fixes #1190063 forcing editoral to reload on back.

- _shouldShowEditorial doesn't take into account the case that the viewmode
hasn't changed, but search has been changed.

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/10227045