lp://staging/~gary/juju-gui/favicon2
- Get this branch:
- bzr branch lp://staging/~gary/juju-gui/favicon2
Branch merges
- Juju GUI Hackers: Pending requested
-
Diff: 2 lines (+0/-0)0 files modified
Branch information
Recent revisions
- 337. By Francesco Banconi
-
Fix ambiguous relation selector
When there are ambiguous relations clicking
to select one or the other does nothing.
This bug affected only our production server,
devel and debug worked well. This is weird,
and I think we are encountering the strange
behavior described in
http://yuilibrary. com/projects/ yui3/ticket/ 2532993
or similar: in some situation (e.g. our production
server, where js files are minified/compressed)
using the "on" method on NodeList does not work.
I am confused about the real reason for this bug.
However, the documentation says that we should
avoid using NodeList.on, in favor of using event
delegation, that is exactly what I did in this
branch. Tests are not included: we have a specific
card for adding tests for the relation module.R=benji, gary.poster
CC=
https://codereview. appspot. com/7177050 - 336. By Benjamin Saller
-
Fix various breakage around menu handling
Fixed issues from merge around method name change and fixed strange
interaction issues with click and dragstart both interacting with the menu on
non-drag events (dragstart it seems is called on any bound targets click).R=frankban, teknico
CC=
https://codereview. appspot. com/7174045 - 335. By Francesco Banconi
-
Allow creating non-FINAL release tarballs.
In the charm, when juju-gui-source is a branch,
a release tarball is created from the checkout
running "NO_BZR=1 make distfile".
The "distfile" target was included in the
released/unreleased check by our Makefile.
This means that trying to deploy the charm
from a branch whose CHANGES.yaml does not
include "unreleased:" always fails with
the error reported by therve:
"non-FINAL releases must have a most-recent
version number of unreleased in CHANGES.yaml".
This branch removes that check from the distfile
target: I think we should protect "dist", but
I don't see, given the problems described above,
a valid reason to continue preventing users
to create non-FINAL tarballs, even if the
branch is a final release.R=teknico, bac
CC=
https://codereview. appspot. com/7189043 - 332. By Benjamin Saller
-
Support for service positions from server
Provides support for loading initial and updated position
from annotations stored on the server. Updates occur
via a shared codepath with the drag event handler
to ensure proper updates are applied over time.There is still an issue with deltas interrupting the drag.
R=gary.poster, frankban
CC=
https://codereview. appspot. com/7132061 - 331. By Brad Crittenden
-
Fix a failing 'service menu' test.
The test set up was incorrect. Simple fix.
R=frankban
CC=
https://codereview. appspot. com/7174043 - 330. By Benji York
-
Fix service menu opening on double-click
This branch was a hand-off. The original was
bzr+ssh://bazaar. launchpad. net/~teknico/ juju-gui/ 1099926- no-svc- menu-on- dblclk/ - 329. By Gary Poster
-
Fix login for Kapil's upcoming rapi branch
The login needed to trigger the dispatch after the "connected" property change, not while it was changing.
R=bac
CC=
https://codereview. appspot. com/7141059
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://staging/juju-gui/experimental