lp://staging/~gary/juju-gui/exposed

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/juju-gui/experimental at revision 594

Juju GUI Hackers: Pending requested 2013-04-23

Diff: 14 lines (+3/-1)

1 file modified

app/views/topology/service.js (+3/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

594. By Gary Poster on 2013-04-23

only draw the exposed indicator once per service block

593. By Madison Scott-Clary on 2013-04-22

TRIVIAL: Dragging ghost services leaves attrs.

If you drag a ghost service and then deploy it, it leaves x and y attributes on the service, which are now removed, ensuring that dragging doesn't cause 'jumping'. A test was added for these attributes.

R=gary.poster, jeff.pihach
CC=
https://codereview.appspot.com/8750047

592. By Benji York on 2013-04-22

Wire up the charm browser "Add" button.

When the "Add" button is clicked the charm configuration panel is displayed
and the user can cancel or deploy.

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/8909044

591. By Jeff Pihach on 2013-04-22

Bug fix: routes being dispatched multiple times

Ever since we added namespace aware routing we have had
an issue which caused routes to be dispatched multiple
times. This stops that from happening while maintaining
the proper browser history entries allowing back/forward
functionality.

R=gary.poster, bcsaller
CC=
https://codereview.appspot.com/8883043

590. By j.c.sackett on 2013-04-22

Fixes fullscreen

Styles fullscreen charm browser and fixes full screen expansion.
(landing for Huw)

R=curtis
CC=
https://codereview.appspot.com/8911043

589. By Francesco Banconi on 2013-04-22

Fix CI failures in Firefox unit tests.

Due to bug https://bugzilla.mozilla.org/show_bug.cgi?id=566671
the unit tests using focus/blur events fail on Firefox.
For some reason, the initial Firefox window is not focused
when the remote webdriver starts executing the GUI unit
tests. This branch adds an explicit call to focus the main
window before running the tests.

R=teknico, gary.poster
CC=
https://codereview.appspot.com/8908043

588. By Madison Scott-Clary on 2013-04-19

Fix resize events for charm panel

Some resize events weren't being caught by the charm panel because they were being fired on the topology, rather than globally.

R=benji, bac
CC=
https://codereview.appspot.com/8872044

587. By Richard Harding on 2013-04-19

TRIVIAL: catch dbl dispatch case in fullscreen.

- In fullscreen the first dispatch correctly displayed the charmid, the second
pass would catch a bad catch-all else that needed to add a small check.
- Test added.

R=
CC=
https://codereview.appspot.com/8827046

586. By Brad Crittenden on 2013-04-19

Fix config update.

The call to set_config was not passing the proper parameters resulting in
the callback not happening. A test has been added to ensure the two
optional parameters are passed properly to ensure this doesn't
happen again.

R=jeff.pihach, teknico
CC=
https://codereview.appspot.com/8702045

585. By Richard Harding on 2013-04-19

Support linking through router code for urls.

- Add state tracking to the subapp and use that to determine which UX parts
need calling and which do not.
- Add an event to the subapp and views to handle catching requests to route to
a new url.
- Add tests to walk the paths of rendering to make sure we're updating and
calling correctly.
- Add some stubs for search, but it's to be implemented in follow up.

R=j.c.sackett, curtis, jeff.pihach
CC=
https://codereview.appspot.com/8726048