Merge lp://staging/~gary/juju-gui/env-help-text into lp://staging/juju-gui/experimental

Proposed by Gary Poster
Status: Merged
Merged at revision: 621
Proposed branch: lp://staging/~gary/juju-gui/env-help-text
Merge into: lp://staging/juju-gui/experimental
Diff against target: 350 lines (+136/-19)
10 files modified
app/assets/javascripts/d3-components.js (+3/-0)
app/store/endpoints.js (+6/-2)
app/templates/overview.handlebars (+11/-0)
app/views/environment.js (+29/-1)
app/widgets/overlay-indicator.js (+2/-3)
lib/views/stylesheet.less (+35/-0)
test/test_environment_view.js (+30/-2)
test/test_panzoom.js (+3/-4)
test/test_service_module.js (+8/-7)
test/utils.js (+9/-0)
To merge this branch: bzr merge lp://staging/~gary/juju-gui/env-help-text
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+161418@code.staging.launchpad.net

Description of the change

Help on empty canvas

The env view should show some help text when the canvas is empty.

Landing work from bcsaller that I modified.

https://codereview.appspot.com/8961049/

To post a comment you must log in.
Revision history for this message
Gary Poster (gary) wrote :

Reviewers: mp+161418_code.launchpad.net,

Message:
Please take a look.

Description:
Help on empty canvas

The env view should show some help text when the canvas is empty.

Landing work from bcsaller that I modified.

https://code.launchpad.net/~gary/juju-gui/env-help-text/+merge/161418

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/8961049/

Affected files:
   A [revision details]
   A app/assets/images/empty_canvas.png
   M app/assets/javascripts/d3-components.js
   M app/store/endpoints.js
   M app/templates/overview.handlebars
   M app/views/environment.js
   M app/widgets/overlay-indicator.js
   M lib/views/stylesheet.less
   M test/test_environment_view.js
   M test/test_panzoom.js
   M test/test_service_module.js
   M test/utils.js

Revision history for this message
Richard Harding (rharding) wrote :

LGTM Thanks for updating.

https://codereview.appspot.com/8961049/

Revision history for this message
Gary Poster (gary) wrote :

*** Submitted:

Help on empty canvas

The env view should show some help text when the canvas is empty.

Landing work from bcsaller that I modified.

R=rharding
CC=
https://codereview.appspot.com/8961049

https://codereview.appspot.com/8961049/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches