Merge lp://staging/~gary/juju-gui/bug1247903 into lp://staging/juju-gui/experimental
| Status: | Merged |
|---|---|
| Merged at revision: | 1179 |
| Proposed branch: | lp://staging/~gary/juju-gui/bug1247903 |
| Merge into: | lp://staging/juju-gui/experimental |
| Diff against target: |
394 lines (+239/-39) 5 files modified
app/store/env/simulator.js (+28/-30) app/templates/unit-action-buttons.handlebars (+1/-1) app/views/viewlets/service-overview.js (+9/-5) test/test_inspector_overview.js (+102/-0) test/test_simulator.js (+99/-3) |
| To merge this branch: | bzr merge lp://staging/~gary/juju-gui/bug1247903 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Juju GUI Hackers | Pending | ||
|
Review via email:
|
|||
Description of the change
Re-enable Landscape sim and fix inspector link
Changes to move units to service attributes broke the Landscape simulation because they were buggy, and we had no tests. Fixing that revealed that Landscape links were broken in the inspector if units appeared with Landscape problems while you observed the inspector. This branch also fixes that problem.
To QA, run the simulator on the sandbox and create 100 or 200 units in a service. Keep the inspector open after creation. You should see a few Landscape issues appear within a few seconds. If you open up the Landscape sections of the inspector, the link to Landscape at the bottom of the section should have a href that looks vaguely like it might point to Landscape, if Landscape were really hooked up.
| Gary Poster (gary) wrote | # |
| Richard Harding (rharding) wrote | # |
| Gary Poster (gary) wrote | # |
| Gary Poster (gary) wrote | # |
Reviewers: mp+193875_
Message:
Please take a look.
Description:
Re-enable Landscape sim and fix inspector link
Changes to move units to service attributes broke the Landscape
simulation because they were buggy, and we had no tests. Fixing that
revealed that Landscape links were broken in the inspector if units
appeared with Landscape problems while you observed the inspector. This
branch also fixes that problem.
To QA, run the simulator on the sandbox and create 100 or 200 units in a
service. Keep the inspector open after creation. You should see a few
Landscape issues appear within a few seconds. If you open up the
Landscape sections of the inspector, the link to Landscape at the bottom
of the section should have a href that looks vaguely like it might point
to Landscape, if Landscape were really hooked up.
Thank you.
https:/
(do not edit description out of merge proposal)
Please review this at https:/
Affected files (+241, -39 lines):
A [revision details]
M app/store/
M app/templates/
M app/views/
M test/test_
M test/test_