lp://staging/~gary/juju-gui/bug1229091
- Get this branch:
- bzr branch lp://staging/~gary/juju-gui/bug1229091
Branch merges
- Juju GUI Hackers: Pending requested
-
Diff: 12 lines (+1/-1)1 file modifiedapp/subapps/browser/templates/browser_charm.handlebars (+1/-1)
Related bugs
Bug #1229091: Charm details should say "Recommended by..." not "Reviewed by..." | Undecided | Fix Released |
Related blueprints
Branch information
Recent revisions
- 1134. By Gary Poster
-
Produce xz distribution tarballs
Per https:/
/codereview. appspot. com/14425057 , change the GUI to produce xz files. See the QA in the other proposal. R=bac
CC=
https://codereview. appspot. com/14494056 - 1133. By Gary Poster
-
Change distfile to exclude unnecessary bits
In order to address the charm deployment problems reported today, this is a first step of two that significantly shrinks the size of our releases. It takes our release down from about 43M to 9M; that brings our charm from about 45M to 11M. I'll make another step (switch from gz to xz) that can bring us down another couple of M. Hopefully that will be sufficient for the problem.
The code is pretty easy to review, but the qa is a bit more tedious. First, please make a distfile (BRANCH_IS_GOOD=1 make distfile) and then follow the instructions I added to the release instructions to test the resulting tarball. Second, add the tarball to a local copy of the charm in the releases directory, remove the 0.10.1 tarball, juju bootstrap, and run make deploy in the charm. Once the charm is deployed, you should be able to see qa the site.
R=frankban
CC=
https://codereview. appspot. com/14516054 - 1132. By Jeff Pihach
-
Bundle topology rendering fails gracefully
If the bundle does not provide proper xy position annotations
on any of the services in its deployer file we do not render
the bundle topology and instead remove the bundle topology
tab, selecting the Charms tab to show the charms the
bundle contains.Because we don't have any bundles with proper positions right
now I added the flag `strictBundle` to enable this feature.R=gary.poster
CC=
https://codereview. appspot. com/14502061 - 1131. By Jeff Pihach
-
Deploy bundles from the bundle detail view
Clicking the 'Deploy' button from the bundle detail view
now deploys the bundle. Also added notifications for this
button and for drag and drop bundle deployment.R=gary.poster
CC=
https://codereview. appspot. com/14419062 - 1130. By Gary Poster
-
After units are deployed, re-enable unit control
R=jeff.pihach
CC=
https://codereview. appspot. com/14512056 - 1129. By Gary Poster
-
Fix Go sandbox AllWatcher initialization
The Go sandbox AllWatcher was trying to send deltas immediately, which does not match the juju core implementation. This fixes the behavior, with a test.
It also fixes a user-visible bug. To qa, turn off the simulator in the config file, and then deploy a service in the default go sandbox. Before my branch, the unit would never appear, because the delta for this change was lost. After my branch, the unit appears correctly.
R=matthew.scott
CC=
https://codereview. appspot. com/14548050 - 1128. By Francesco Banconi
-
Update the release process documentation.
Added the charm release steps.
R=rharding
CC=
https://codereview. appspot. com/14531051 - 1127. By Jeff Pihach
-
Deletes the databindings when they are detached
Because the left panel slot on the inspector gets destroyed
when switching between the unit/charm details views the databinding
would attempt to rebind to elements which didn't exist any longer.This branch handles removing the databindings from the master list
of bindings when they are detached.R=benjamin.saller
CC=
https://codereview. appspot. com/14489044 - 1126. By Benjamin Saller
-
Fix annotations on go backend
Fix annotation roundtrips with go backend
Splits how we prepare deltas for py/go juju fakebackends
Change test expectations to merge updateAnnotation callsFix import of constraints
Fix export of undefined/default valuesAdjust simulator unit count rate of change.
R=benjamin.saller, gary.poster, jeff.pihach
CC=
https://codereview. appspot. com/14485046
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://staging/juju-gui/experimental