lp://staging/~gary/juju-gui/bug1167295

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/juju-gui/experimental at revision 533

Juju GUI Hackers: Pending requested 2013-04-10

Diff: 219 lines (+84/-10)

7 files modified

app/templates/unit.handlebars (+1/-1)
app/views/topology/relation.js (+4/-4)
app/views/utils.js (+35/-0)
lib/views/stylesheet.less (+1/-0)
test/test_environment_view.js (+14/-3)
test/test_topology_relation.js (+4/-2)
test/test_utils.js (+25/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1167307: GUI/juju-core: errors adding a relation

High

Fix Released

Link a bug report

Related blueprints

533. By Gary Poster on 2013-04-10

fix lint and refactor to move DOM id function to view utils.

532. By Gary Poster on 2013-04-10

make go relations use dom-friendly ids in the environment view. also fix some css regressions to make some text readable again.

531. By j.c.sackett on 2013-04-10

Removes remaining references to charm slider

While the slider is gone, there were elements that still expected slider data;
sliderCharms, sliderContainers, and the slider class in the template.

All of these things are replaced by "featured" (e.g. featuredCharms), which is
the new container category replacing the slider in the design.

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/8600043

530. By Richard Harding on 2013-04-10

Update the charm details to show changelog detail

- Update the model to pull/parse the commit data from the source_code data
- add some model tests around the parsing of the commit data and a couple of
other model attrs
- Update the view to handle getting the commit data into stuff that's
handlebars friendly
- update to display/show/hide changelog details.

R=j.c.sackett, jeff.pihach
CC=
https://codereview.appspot.com/8621043

529. By Jeff Pihach on 2013-04-10

Implemented add-relation for the fakebackend

In order to implement add-relation for the fakebackend
a large change was needed in the fake charmstore in
tests/utils.js in order to allow us to load in real
charm data.

Add-relation also appears to be the only command which
has it's input data altered in the python.js endpoint
so it needs to support two different types of input
while maintaining as close to identical responses.

R=bcsaller, gary.poster
CC=
https://codereview.appspot.com/8578043

528. By Nicola Larosa on 2013-04-10

Add destroy_service to the Go environment.

Add destroy_service to the Go environment, with tests.

Remove handleSetConfig from the Go environment: it is the same
as handleServiceCalls, used in its place.

Add tests for destroy_service to the Python environment too.

Increase the timeout in the test's index.html, to make debug tests
pass on my slow machine.

R=frankban, bac
CC=
https://codereview.appspot.com/8618043

527. By Brad Crittenden on 2013-04-10

Change Go get_service results to match others.

Also bolster tests.

R=teknico, gary.poster
CC=
https://codereview.appspot.com/8623043

526. By Francesco Banconi on 2013-04-10

Go delta stream: fix Status/StatusInfo handling

Unit's and machine's StatusInfo is now stored in the database,
and displayed in the unit detail view using a handlebars
helper. Note that StatusInfo is only displayed if it's
not an empty string.

Also updated the way Status and StatusInfo are stored
in machine instances: now machines have their own
status in the delta stream.

R=teknico, bac
CC=
https://codereview.appspot.com/8614043

525. By Gary Poster on 2013-04-10

Fix environment annotations

Environment annotations were being munged inappropriately, breaking our Landscape integration. This fixes that.

Also, not all hyphens were being converted to underlines in delta attribute names, only the first one. This fixes that too.

R=
CC=
https://codereview.appspot.com/8607043

524. By Madison Scott-Clary on 2013-04-09

Keep touch events from colliding

Taps were being interpreted as drags as well as clicks, and services were being moved due to the way that touch events were being handled. In order to clean this up, dragging now takes place with two (or more) fingers, and clicking with one finger. Additionally, tap-to-click was toggling the service menu twice, and that is now being prevented. This applies to Ubuntu Touch devices and causes trouble for some Android devices (bug #1167005)

R=gary.poster, rharding
CC=
https://codereview.appspot.com/8362048