lp://staging/~gary/juju-gui/authtoken

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/juju-gui/experimental at revision 1213

Juju GUI Hackers: Pending requested 2013-11-26

Diff: 1162 lines (+790/-126)

11 files modified

app/app.js (+94/-19)
app/store/env/fakebackend.js (+21/-0)
app/store/env/go.js (+51/-3)
app/store/env/sandbox.js (+32/-3)
app/views/login.js (+8/-2)
test/test_app.js (+186/-2)
test/test_env_go.js (+208/-97)
test/test_fakebackend.js (+31/-0)
test/test_login.js (+1/-0)
test/test_sandbox_go.js (+87/-0)
test/utils.js (+71/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1214. By Gary Poster on 2013-11-26

respond to review

1213. By Gary Poster on 2013-11-26

merge trunk

1212. By Gary Poster on 2013-11-26

tests, docs, and lint

1211. By Gary Poster on 2013-11-26

fixes

1210. By Gary Poster on 2013-11-25

add basic authtoken support

1209. By Huw Wilkins on 2013-11-25

Add animations to browser

I had a bit of a realisation about how we could do open animations for the browser panels. It seems to QA accross browsers and even though the panels don't animate on close I think it's worth having.

I'm hoping this might be enough that we don't have to worry about animations on close...

There is one point which might be considered a bug in that the panels will animate in on page load instead of remaining in the open state. I think this is an OK trade off, but others may feel differently.

R=jeff.pihach
CC=
https://codereview.appspot.com/31930043

1208. By Richard Harding on 2013-11-21

Display bundle download counts in the UI.

- Update the model to carry the attribute from the api.
- Update the token to display the "Deployed X times".
- Update the details to also display the count.
- Drive-by to update the attributes in the charm model.
- Update tests with updated api download from the server that includes the
download counts. Required updating tests to the new data.

R=jeff.pihach
CC=
https://codereview.appspot.com/30210044

1207. By Brad Crittenden on 2013-11-21

Send bundle id when d'n'd from sidebar.

This path was initially missed. The Token had to be fixed to include the
ID in the drag data.

Note, for selfish reasons, test/utils.js loadFixtures was updated to retry on
failures. The reason for the occassional 404 in this function when run by
lbox is still unknown. Hopefully the dumb retry will help.

QA Instructions:

# Use juju-quickstart trunk
% cd projects/juju-quickstart
% bzr pull
% make
# Deploy on EC2
% juju switch ec2
% .venv/bin/python juju-quickstart --gui-charm-url cs:~juju-gui/precise/juju-gui-128
% juju set juju-gui "juju-gui-source=lp:~bac/juju-gui/fix-dnd-bundles-wrt-id"
# May want to wait a bit. Perhaps it isn't necessary.
% juju set juju-gui "charmworld-url=http://staging.jujucharms.com"

Find one of Jorge's bundles on http://staging.jujucharms.com.
(wordpress-simple is a fast one.) Look at the deployment counts.

In the GUI search for 'jorge', find the bundle from above, and *drag* it onto
the canvas. Have a light snack. When everything is green and happy, look at
the page again on staging and see that the count has increased by one. NOTE:
in my QA I didn't see the incremented values reflected immediately which is
really strange. A few minutes later they were updated.

R=benji
CC=
https://codereview.appspot.com/29960045

1206. By Richard Harding on 2013-11-20

fakebackend/sandbox no op deployer watches

- The fakebackend and the sandbox need to just ignore calls to watch deployer
status. It's too fast and we don't want to flood the users with a bunch of
notices all at once.
- Had to rename the WatchUpdate to deployerNext since the fakebackend auto
builds the names of the handle methods based off the actual call. So it needed
to be deployerNext though I hate it's no longer worded to tie to 'watch'.

QA:

Simply deploy a bundle in sandbox mode.

- Drag/drop a yaml file into the canvas
- Deploy from the deploy button from bundle details

Note: Dragging/dropping a bundle token is not working. This is also true on
coming soon. This is due to the recent bundle.id tracking code and will be
done in a follow up.

R=bac
CC=
https://codereview.appspot.com/29860044

1205. By Jeff Pihach on 2013-11-20

Adds agent_state_data(SourceData) support

The simulator and juju-core return SourceData along with any
error messages. These are now displayed in the unit details
left breakout panel in the new inspector.

I also removed an unused template from the old inspectors and
modified some css to make the left panel react properly to
varying unit detail header heights.

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/29400043