lp://staging/~gary/charms/precise/juju-gui/legacyJujucharms
- Get this branch:
- bzr branch lp://staging/~gary/charms/precise/juju-gui/legacyJujucharms
Branch merges
- charmers: Pending requested
-
Diff: 35 lines (+13/-1)2 files modifiedhooks/utils.py (+1/-1)
tests/test_utils.py (+12/-0)
Branch information
- Owner:
- Gary Poster
- Status:
- Development
Recent revisions
- 130. By Francesco Banconi
-
Improve charm test venv creation.
Also added missing SYSDEP.
R=gary.poster
CC=
https://codereview. appspot. com/26530043 - 127. By Francesco Banconi
-
Fix base Python dependencies.
The install hook imported charmhelpers
before installing python-yaml, and
charmhelpers imports from yaml.This very old bug has been hidden by the
fact that python-yaml is automatically
installed in ec2/lxc instances, but showed
itself when using the manual provider.Copy/pasting and integrating the QA from
my last branch, a double check can help
before the release.
QA:
- Bootstrap a Juju environment with --debug.
- Deploy and expose the GUI (make deploy).
- Check juju debug-log (or
less ~/.juju/local/log/ unit-juju- gui-0.log if you
used lxc): you should see the following message
at the beginning of the install hook log:
"Installing base Python dependencies: python-apt,
python-launchpadlib, python-tempita, python-yaml."
- Wait for the GUI to be ready/started.
- Deploy this bundle: http://pastebin. ubuntu. com/6411548/
- Check everything is ok, xy annotations work (
the services are vertically aligned), wordpress has
customized constraints, mysql customized options and
two units.
- No try to deploy the same bundle again, you
will see a "services already there" kind of error.R=gary.poster
CC=
https://codereview. appspot. com/26190043 - 126. By Francesco Banconi
-
Update requirements and improve their handling.
Updated the juju-deployer and jujucleint
dependencies to the latest versions, which
include our recent fixes. This way we avoid
using our own forks of the projects.Updated the code that installs the builtin
server dependencies: now a pip requirement
file is used, and the test requirement file
includes the former. The overall dependency
infrastructure should now be less confusing.Also added documentation about how to update
the builtin server requirements.Removed the no longer required --upload-tools
from the functional tests runner.The deployer functional tests now also use
bundles including numunits > 1 and constraints.QA:
- Bootstrap a Juju environment.
- Deploy and expose the GUI (make deploy).
- Wait for the GUI to be ready/started.
- Deploy this bundle: http://pastebin. ubuntu. com/6411548/
- Check everything is ok, xy annotations work (
the services are vertically aligned), wordpress has
customized constraints, mysql customized options and
two units.
- No try to deploy the same bundle again, you
will see a "services already there" kind of error.R=gary.poster
CC=
https://codereview. appspot. com/26130043 - 125. By Brad Crittenden
-
Ensure JUJU_ENV is set when required.
R=jeff.pihach
CC=
https://codereview. appspot. com/24790045 - 122. By Francesco Banconi
-
Improve bundle deployment error handling.
Workaround for http://
bugs.python. org/issue169233 5. Include a customized jujuclient tarball in the
charm, The diff with the original is here:
http://pastebin. ubuntu. com/6377430/ Add a first fix to the testing environment creation
so that the local dependencies are installed
when available.Also fixed the headers sent by the info handler.
Tests: make unittest
QA:
I used this bundle: http://pastebin. ubuntu. com/6377441/
to live test the branch.
Bootstrap a juju environment, run `make deploy` and then
switch the gui source to lp:juju-gui.
When everything is ready, try to deploy the bundle above:
it will fail because it includes local charms, but the
server will not explode, and it will be possible
to deploy other valid bundles after the first one.
The GUI user does not receive notifications, and that's
normal since deployments are not yet watched by the GUI.
Go to https://[GUI URL]/gui-server- info and you should
find the deployment status to be completed with the
expected error.R=rharding, bac
CC=
https://codereview. appspot. com/23000043
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://staging/charms/juju-gui