Juju Charms Collection
buildbot-slave package

Merge lp://staging/~gary/charms/oneiric/buildbot-slave/extra-packages into lp://staging/~yellow/charms/oneiric/buildbot-slave/trunk

  1. Oneiric (11.10)
  2. extra-packages
  3. Merge into trunk
Proposed by Gary Poster
Status: Merged
Merged at revision: 23
Proposed branch: lp://staging/~gary/charms/oneiric/buildbot-slave/extra-packages
Merge into: lp://staging/~yellow/charms/oneiric/buildbot-slave/trunk
Diff against target: 50 lines (+14/-0)
3 files modified
config.yaml (+8/-0)
examples/lpbuildbot.yaml (+1/-0)
hooks/config-changed (+5/-0)
To merge this branch: bzr merge lp://staging/~gary/charms/oneiric/buildbot-slave/extra-packages
Reviewer Review Type Date Requested Status
Benji York (community) code Approve
Review via email: mp+93515@code.staging.launchpad.net

Description of the change

This branch moves over the extra-packages feature from the buildbot-master. LP needs it for parallel testing, as shown by the included config change.

To post a comment you must log in.
Revision history for this message
Benji York (benji) wrote :

This looks good.

A small redundancy: there's no need for the .strip() because the split
will remove any leading, trailing, or duplicate whitespace around the
package names.

review: Approve (code)
lp://staging/~gary/charms/oneiric/buildbot-slave/extra-packages updated
15. By Gary Poster

[r=bac] move HACKING to README per review

16. By Francesco Banconi

[r=gmb] Added revision file. Removed juju_wrapper.

17. By Brad Crittenden

[r=frankban] Install python-shell-toolbox in the install hook. Temporarily add copies of helpers.py and local.py until a proper sharing solution is implemented. These files are to be edited in the buildbot-master and kept in sync.

18. By Benji York

correct the buildbot home dir

19. By Benji York

[r=gary] add a work-around to a bug in LXC

20. By Francesco Banconi

[r=gmb] upgrade-charm hook.

21. By Benji York

- tweak the lpbuildbot example config to specify alternate key names
- make the buildbot group creation unconditional
- add a --yes when adding a repository

22. By Benji York

merge from trunk

23. By Gary Poster

add extra-packages functionality, as with buildbot-master. We need it to include testrepository.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: