Merge lp://staging/~gary/charms/oneiric/buildbot-master/expand-readme into lp://staging/~yellow/charms/oneiric/buildbot-master/trunk

Proposed by Gary Poster
Status: Merged
Approved by: Brad Crittenden
Approved revision: 36
Merged at revision: 35
Proposed branch: lp://staging/~gary/charms/oneiric/buildbot-master/expand-readme
Merge into: lp://staging/~yellow/charms/oneiric/buildbot-master/trunk
Diff against target: 137 lines (+75/-41)
2 files modified
HACKING.txt (+0/-30)
README.txt (+75/-11)
To merge this branch: bzr merge lp://staging/~gary/charms/oneiric/buildbot-master/expand-readme
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Review via email: mp+95029@code.staging.launchpad.net

Description of the change

This branch adjusts the charm per our recent review: we collapse HACKING into README.

I also added and massaged the README a bit, including making some changes to accommodate changes in the sister branch https://code.launchpad.net/~gary/charms/oneiric/buildbot-slave/expand-readme .

Thank you

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

Looks good.

To be more obvious I'd expand "OOM".

I thought the juju_wrapper was going to be moved somewhere else. Let's remember to fix this README when that happens.

review: Approve (code)
37. By Gary Poster

tweak per review

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: