Code review comment for lp://staging/~gary-wzl77/net-cpp/dual_landing_support

Revision history for this message
James Henstridge (jamesh) wrote :

The recent changes are looking a lot better. Here's an updated abidiff report after disabling -fvisibility=hidden: http://paste.ubuntu.com/23066000/

Just a few small issues with the changes in the most recent revision:

1. for the new symbols you've added to the .symbols files, set the version number to "0replaceme" rather than "2.1.0-0ubuntu1". CI Train will automatically replace that tag with the final version number for the released package.

2. I notice you've made a variable and two functions in src/core/net/http/impl/curl/request.h static. Was there any particular reason for this? My understanding is that this will result in the variable being instantiated once for each file the header is included in, which seems unnecessary.

The symbols are hidden anyway, so it doesn't improve things from an ABI perspective.

« Back to merge proposal