Merge lp://staging/~gary-wzl77/day-scope/arch_and_shadow_build into lp://staging/day-scope

Proposed by Gary.Wang
Status: Merged
Approved by: Kyle Nitzsche
Approved revision: 52
Merged at revision: 52
Proposed branch: lp://staging/~gary-wzl77/day-scope/arch_and_shadow_build
Merge into: lp://staging/day-scope
Diff against target: 69 lines (+15/-9)
2 files modified
CMakeLists.txt (+14/-8)
manifest.json.in (+1/-1)
To merge this branch: bzr merge lp://staging/~gary-wzl77/day-scope/arch_and_shadow_build
Reviewer Review Type Date Requested Status
Kyle Nitzsche (community) Approve
Review via email: mp+299903@code.staging.launchpad.net

Commit message

1.detect arch when cmake to make sure click package name correct.
2.do not generate file in build-in source folder when shadow build.

Description of the change

1.detect arch when cmake to make sure click package name correct.
2.do not generate file in build-in source folder when shadow build.

To post a comment you must log in.
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: