Ubuntu Software Center

Merge lp://staging/~gary-lasker/software-center/recommender-test-fix into lp://staging/software-center

recommender-test-fix
Merge into trunk

Proposed by Gary Lasker on 2012-09-11

Status:	Merged
Merged at revision:	3159
Proposed branch:	lp://staging/~gary-lasker/software-center/recommender-test-fix
Merge into:	lp://staging/software-center
Diff against target:	66 lines (+9/-8) 1 file modified tests/gtk3/test_catview.py (+9/-8)
To merge this branch:	bzr merge lp://staging/~gary-lasker/software-center/recommender-test-fix
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Michael Vogt (community)		2012-09-11	Approve on 2012-09-11
Review via email: mp+123669@code.staging.launchpad.net

Commit message

* lp:~gary-lasker/software-center/recommender-test-fix:
- update the recommender feedback unit test to work on systems
that are not opted-in

Description of the change

This branch fixes the test_implicit_recommender_feedback unit test so that it will work on systems that are not actually opted-in to the recommendations service. I've removed the corresponding unittest.skipIf for this test. Note that this fix also takes care of the "ValidationException: Argument 'uuid' must match pattern '[\dabcdef]{32}$'" exceptions that are thrown for some of the other tests.

Thank you for your review!

Revision history for this message

Michael Vogt (mvo) wrote on 2012-09-11:

Thanks, looks good.

The test failed for me when running it initially with the following error:
======================================================================
FAIL: test_recommended_for_you_spinner_display (__main__.RecommendationsTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "tests/gtk3/test_catview.py", line 162, in test_recommended_for_you_spinner_display
self.rec_panel.recommended_for_you_content.get_property("visible"))
AssertionError: False is not true

----------------------------------------------------------------------
Ran 9 tests in 19.177s

but subsequent runs worked, it seems to be random, maybe 1 out 5. And I doubt its releated
to this branch so I will merge it. But it would be nice if that could be investigated.

review: Approve

Revision history for this message

Gary Lasker (gary-lasker) wrote on 2012-09-11:

I have seen this test failure myself for a while now, for me it happens about one out of 10 runs, and I just haven't had the chance to investigate it. Indeed, it is completely unrelated to anything in this branch. It seems like just a race issue in the test as I personally have not seen problems in this area in the real code.