lp://staging/~gary-lasker/software-center/recommendations-sso-login-lp973612

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/software-center at revision 2989

software-store-developers: Pending requested 2012-04-16

Diff: 131 lines (+66/-4)

2 files modified

softwarecenter/backend/login_sso.py (+3/-2)
softwarecenter/ui/gtk3/widgets/recommendations.py (+63/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #967064: Opting in to recommendations asks you to sign in with the wrong text	High	Fix Released
Bug #973612: Turning on "Recommended For You" spins forever after previously cancelling sign-in	Medium	Fix Released

Link a bug report

Related blueprints

2988. By Gary Lasker on 2012-04-19

merge with trunk

2987. By Gary Lasker on 2012-04-18

really fix the case on startup if there is no network connection

2986. By Gary Lasker on 2012-04-17

revert the whoami_error fix as we also get these in the case where the user's token has been revoked or invalidated on the server side (so we do need to fully opt-out in this case), also, handle an sso login-failed event

2985. By Gary Lasker on 2012-04-16

if there is an error in the whois query, we can assume a network connectivity issue, so we simply hide the recommendations panel as we do for the case where we can't reach the recommendations server

2984. By Gary Lasker on 2012-04-16

log when the user has cancelled the authorization dialog

2983. By Gary Lasker on 2012-04-16

login-canceled is more appropriate for the case where the user has canceled the auth dialog

2982. By Gary Lasker on 2012-04-15

make the purpose of the fixme comment more clear

2981. By Gary Lasker on 2012-04-15

pep8 fixes

2980. By Gary Lasker on 2012-04-15

log a warning instead of a scary error in the case where the Ubuntu SSO dialog is canceled by the user (this is a perfectly valid choice and should not be considered an error, seems to me), also, fire a login-failed signal for this case so that listeners can handle it

2979. By Gary Lasker on 2012-04-15

fix the delay before showing a spinner when checking the Ubuntu SSO status