Merge lp://staging/~gary-lasker/software-center/fix-lp969907-for-5.2 into lp://staging/software-center/5.2
Status: | Merged |
---|---|
Approved by: | Michael Vogt |
Approved revision: | 3065 |
Merge reported by: | Michael Vogt |
Merged at revision: | not available |
Proposed branch: | lp://staging/~gary-lasker/software-center/fix-lp969907-for-5.2 |
Merge into: | lp://staging/software-center/5.2 |
Diff against target: |
89 lines (+19/-19) 1 file modified
softwarecenter/ui/gtk3/widgets/apptreeview.py (+19/-19) |
To merge this branch: | bzr merge lp://staging/~gary-lasker/software-center/fix-lp969907-for-5.2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Vogt (community) | Approve | ||
Review via email: mp+115461@code.staging.launchpad.net |
Description of the change
This branch should fix the crasher in bug 969907. Unfortunately, I could not find a way to reproduce this crash, but it has been consistently appearing on errors.ubuntu.com so we need to fix this. Basically, the fix consists in checking for a null model on the call to _app_activated_
I also made a change earlier in the chain, in the _on_key_
I also did a small amount of cleanup to the code in _app_activated_
Testing should be done in the various listviews, that is, to use both the "More Info" and the "Install/Remove" buttons in the listviews for both the "All Software" and "Installed" views (the latter tests the treeview case).
Thanks for your review!
Thanks a lot for this branch! I have a bit of a busy morning so I will review it a bit later today, this is just a quick note to say that its great that you looked at the problem and analyzed it.