Merge lp://staging/~gagern/bzr/bug560030-drop-completions into lp://staging/bzr

Proposed by Martin von Gagern
Status: Rejected
Rejected by: Vincent Ladeuil
Proposed branch: lp://staging/~gagern/bzr/bug560030-drop-completions
Merge into: lp://staging/bzr
Diff against target: 456 lines (+17/-420)
4 files modified
contrib/bash/README (+8/-0)
contrib/bash/bzr (+0/-104)
contrib/zsh/README (+9/-0)
contrib/zsh/_bzr (+0/-316)
To merge this branch: bzr merge lp://staging/~gagern/bzr/bug560030-drop-completions
Reviewer Review Type Date Requested Status
Martin von Gagern (community) Disapprove
Vincent Ladeuil Approve
Review via email: mp+23224@code.staging.launchpad.net

Description of the change

Dropping bash and zsh completion functions according to bug #560030, as I see no value in them. Added README files to propose alternatives instead.

Keeping bash/bzr.simple as it isn't really outdated, and therefore might have some value still. That would change if the bzr-bash-completion plugin got integrated into bzr itself.

Haven't added a NEWS item yet. If you want one, please suggest a section title, as none of the established ones seems to apply particularly well.

To post a comment you must log in.
Revision history for this message
Martin von Gagern (gagern) wrote :

I've recently signed the canonical contributor agreement, which might make merging this thing here a bit easier.

Revision history for this message
Vincent Ladeuil (vila) wrote :

Thanks for the cleanup.

review: Approve
Revision history for this message
Robert Collins (lifeless) wrote :

I've commented on the bug, I'd like to know that answer before voting here.

Revision history for this message
Martin von Gagern (gagern) wrote :
review: Disapprove

Unmerged revisions

5148. By Martin von Gagern

Drop outdated shell completions for bash and zsh.

There are new README files in the corresponding directories indicating
suggested alternatives instead.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.