hw-health-charm

Merge ~gabrielcocenza/charm-hw-health:charm-snap into charm-hw-health:master

  1. Git
  2. lp:~gabrielcocenza/charm-hw-health
  3. charm-snap
  4. Merge into master
Proposed by Gabriel Cocenza
Status: Merged
Approved by: Eric Chen
Approved revision: 4572c4a9af66b44fc0afee3d21b6fd21d95fcfa2
Merged at revision: 415897cb37eb5e74cc13b9e9de16676f70280582
Proposed branch: ~gabrielcocenza/charm-hw-health:charm-snap
Merge into: charm-hw-health:master
Diff against target: 15 lines (+3/-1)
1 file modified
charmcraft.yaml (+3/-1)
Reviewer Review Type Date Requested Status
Eric Chen Needs Information
🤖 prod-jenkaas-bootstack continuous-integration Approve
BootStack Reviewers Pending
Review via email: mp+442308@code.staging.launchpad.net

Commit message

Pin charm snap version as a temporary fix.

- build start failing because of a incompatibility issue with
charmcraft and charm snap.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

PASSED: Continuous integration, rev:4572c4a9af66b44fc0afee3d21b6fd21d95fcfa2
https://jenkins.canonical.com/bootstack/job/lp-charm-hw-health-ci/4/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/bootstack/job/lp-charm-test-unit/15/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/255/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-hw-health-ci/4//rebuild

review: Approve (continuous-integration)
Revision history for this message
Eric Chen (eric-chen) wrote :

Why we didn't encounter this issue 2 weeks before and we already had 23.04 release?

review: Needs Information
Revision history for this message
Gabriel Cocenza (gabrielcocenza) wrote (last edit ):

I'm also very suprised that this error didn't show up before.

I didn't investigate the deep details why this didn't happen 2 weeks ago, but the facts are:

- it's failing to build on launchpad[0] and also on my local machine (it wasn't some days ago).
- the logs[1] show that it's a C dependency issue (lines 1509-1514):
- we already faced that before in other reactive charms using charmcraft.yaml (charm-telegraf [2])
- strangely, just the latest/stable release of the snap `charm`[3] got updated recently (6 April 2023)
- setting the dependency to 3.x/stable didn't fix.
- setting the dependency to 2x/stable fix it.

[0] https://launchpadlibrarian.net/664448358/buildlog_charm_ubuntu_jammy_amd64_daily_BUILDING.txt.gz
[1] https://pastebin.canonical.com/p/Z7bmn9xtXK/
[2] https://chat.canonical.com/canonical/pl/otwweyx5pbb6b8cbngowzzyg4h
[3] https://snapcraft.io/charm

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 415897cb37eb5e74cc13b9e9de16676f70280582

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: