Merge ~gabriel-samfira/simplestreams:use-region-name into simplestreams:master

Proposed by Gabriel Samfira
Status: Needs review
Proposed branch: ~gabriel-samfira/simplestreams:use-region-name
Merge into: simplestreams:master
Diff against target: 54 lines (+10/-4)
2 files modified
simplestreams/mirrors/glance.py (+1/-1)
simplestreams/objectstores/swift.py (+9/-3)
Reviewer Review Type Date Requested Status
Erlon R. Cruz (community) Needs Fixing
simplestreams-dev Pending
Review via email: mp+452267@code.staging.launchpad.net

Commit message

When using a multi-region shared keystone, we must pass in the region or at least an endpoint overide to the glance and keystone clients, otherwise the wrong region can be selected from the shared keystone session, as the same keystone is responsible for multiple regions.

To post a comment you must log in.
Revision history for this message
Erlon R. Cruz (sombrafam) wrote :

How did you test this change? I would expect code to add, parse, and store --region, but I don't see any.

review: Needs Fixing

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches