Merge lp://staging/~fwierzbicki/txstatsd/add-helpers into lp://staging/txstatsd

Proposed by Frank Wierzbicki
Status: Merged
Approved by: Ian Wilkinson
Approved revision: 36
Merged at revision: 33
Proposed branch: lp://staging/~fwierzbicki/txstatsd/add-helpers
Merge into: lp://staging/txstatsd
Diff against target: 45 lines (+36/-0)
2 files modified
txstatsd/metrics/imetrics.py (+18/-0)
txstatsd/tests/helper.py (+18/-0)
To merge this branch: bzr merge lp://staging/~fwierzbicki/txstatsd/add-helpers
Reviewer Review Type Date Requested Status
Ian Wilkinson (community) Approve
Review via email: mp+74693@code.staging.launchpad.net

Description of the change

This branch extracts a couple of txstatsd related test utilities and a Zope interface from the Landscape codebase written by Sidnei. We need them in both Cloud Deck and Landscape now, and we where hoping we could keep them with the txstatsd project instead of artificially pushing the code to Cloud Deck.

To post a comment you must log in.
Revision history for this message
Ian Wilkinson (theiw) wrote :

Would you be comfortable if:

* txstatsd/zope/interfaces.py became txstatsd/metrics/imetrics.py

and,

* txstatsd/testing.py became txstatsd/tests/helper.py

review: Needs Information
Revision history for this message
Frank Wierzbicki (fwierzbicki) wrote :

> Would you be comfortable if:
>
> * txstatsd/zope/interfaces.py became txstatsd/metrics/imetrics.py
>
> and,
>
> * txstatsd/testing.py became txstatsd/tests/helper.py
That works fine for me - I will go ahead and change them accordingly.

36. By Frank Wierzbicki

Renames based on input from theiw.

Revision history for this message
Ian Wilkinson (theiw) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches