Code review comment for lp://staging/~fwereade/pyjuju/upstartify-services

Revision history for this message
William Reade (fwereade) wrote :

More detail:

UpstartService.start now checks that the job's pid is stable (5 checks over 0.4s), and raises a ServiceError if it isn't (including, where available, the stdout/stderr written out from the exec line in the job conf).

Local provider file storage now runs with user's uid/gid.

UnitMachineDeployment is now functionally tested (kind of, anyway; it's using dummy agent, as before).

« Back to merge proposal