Code review comment for lp://staging/~fwereade/pyjuju/upstartify-services

Revision history for this message
Jim Baker (jimbaker) wrote :

+1. Agreed about the diffs, pretty easy to grok this branch. Just one small thing I found:

[1]

+ def mock_start(self):
+ self.check_call(("/sbin/start", "juju-wordpress-0"))
+ self.mocker.result(None)

Should be self.mocker.result(0)

+
+ def mock_destroy(self):
+ self.check_call(("/sbin/stop", "juju-wordpress-0"))
+ self.mocker.result(None)

Ditto

review: Approve

« Back to merge proposal