+1. Agreed about the diffs, pretty easy to grok this branch. Just one small thing I found:
[1]
+ def mock_start(self): + self.check_call(("/sbin/start", "juju-wordpress-0")) + self.mocker.result(None)
Should be self.mocker.result(0)
+ + def mock_destroy(self): + self.check_call(("/sbin/stop", "juju-wordpress-0")) + self.mocker.result(None)
Ditto
« Back to merge proposal
+1. Agreed about the diffs, pretty easy to grok this branch. Just one small thing I found:
[1]
+ def mock_start(self): call((" /sbin/start" , "juju-wordpress -0")) result( None)
+ self.check_
+ self.mocker.
Should be self.mocker. result( 0)
+ call((" /sbin/stop" , "juju-wordpress -0")) result( None)
+ def mock_destroy(self):
+ self.check_
+ self.mocker.
Ditto