Merge lp://staging/~fwereade/pyjuju/fix-mocking into lp://staging/pyjuju
Proposed by
William Reade
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Gustavo Niemeyer | ||||
Approved revision: | 281 | ||||
Merged at revision: | 285 | ||||
Proposed branch: | lp://staging/~fwereade/pyjuju/fix-mocking | ||||
Merge into: | lp://staging/pyjuju | ||||
Diff against target: |
173 lines (+64/-16) 4 files modified
ensemble/providers/ec2/tests/common.py (+12/-7) ensemble/providers/ec2/tests/test_bootstrap.py (+4/-4) ensemble/providers/ec2/tests/test_launch.py (+48/-4) ensemble/providers/ec2/utils.py (+0/-1) |
||||
To merge this branch: | bzr merge lp://staging/~fwereade/pyjuju/fix-mocking | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gustavo Niemeyer | Approve | ||
Kapil Thangavelu (community) | Approve | ||
Jim Baker | Pending | ||
Review via email: mp+68925@code.staging.launchpad.net |
Description of the change
Tests now run with no network.
Not sure how to reliably induce a flaky network to see whether it affects possibly-related timeouts.
Coverage of the code we were failing to mock correctly is now improved.
To post a comment you must log in.
looks good, and works nicely disconnected.