Merge lp://staging/~fwereade/pyjuju/find-all-zookeepers into lp://staging/pyjuju
Proposed by
William Reade
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Gustavo Niemeyer | ||||
| Approved revision: | 313 | ||||
| Merged at revision: | 313 | ||||
| Proposed branch: | lp://staging/~fwereade/pyjuju/find-all-zookeepers | ||||
| Merge into: | lp://staging/pyjuju | ||||
| Diff against target: |
145 lines (+37/-22) 4 files modified
ensemble/providers/common/findzookeepers.py (+4/-3) ensemble/providers/common/tests/test_findzookeepers.py (+8/-5) ensemble/providers/ec2/tests/test_findzookeeper.py (+7/-5) ensemble/providers/orchestra/tests/test_findzookeepers.py (+18/-9) |
||||
| To merge this branch: | bzr merge lp://staging/~fwereade/pyjuju/find-all-zookeepers | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gustavo Niemeyer | Approve | ||
|
Review via email:
|
|||
Description of the change
Fix lp:823511 (we only find one zookeeper, even if several exist).
Did this because forthcoming common zookeeper-connect code is quite neat if it works with multiple machines, and I got tired of seeing the TODO.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
William confirmed on IRC that the call sites won't break with more than one machine.
It's not clear what's the goal here, but that's ok.