Merge lp://staging/~fwereade/juju-core/cosmetic-status-output into lp://staging/~juju/juju-core/trunk
Proposed by
William Reade
Status: | Merged |
---|---|
Merged at revision: | 1186 |
Proposed branch: | lp://staging/~fwereade/juju-core/cosmetic-status-output |
Merge into: | lp://staging/~juju/juju-core/trunk |
Diff against target: |
54 lines (+11/-11) 1 file modified
cmd/juju/status.go (+11/-11) |
To merge this branch: | bzr merge lp://staging/~fwereade/juju-core/cosmetic-status-output |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju Engineering | Pending | ||
Review via email: mp+159818@code.staging.launchpad.net |
Description of the change
cmd/juju: alphabetise status output fields
To post a comment you must log in.
Reviewers: mp+159818_ code.launchpad. net,
Message:
Please take a look.
Description:
cmd/juju: alphabetise status output fields
https:/ /code.launchpad .net/~fwereade/ juju-core/ cosmetic- status- output/ +merge/ 159818
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/8834047/
Affected files:
A [revision details]
M cmd/juju/status.go
Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>
Index: cmd/juju/status.go status. go'
=== modified file 'cmd/juju/
--- cmd/juju/status.go 2013-04-18 14:18:36 +0000
+++ cmd/juju/status.go 2013-04-19 12:45:35 +0000
@@ -309,14 +309,14 @@
type machineStatus struct { series, omitempty" omitempty" ` instance- id,omitempty" id,omitempty" ` dns-name, omitempty" name,omitempty" ` life,omitempty" omitempty" ` agent-version, omitempty" version, omitempty" ` agent-state, omitempty" state,omitempty "` agent-state- info,omitempty" state-info, omitempty" ` agent-version, omitempty" version, omitempty" ` dns-name, omitempty" name,omitempty" ` instance- id,omitempty" id,omitempty" ` instance- state,omitempty " state,omitempty "` life,omitempty" omitempty" ` series, omitempty" omitempty" `
Err error `json:"-" yaml:",omitempty"`
- Series string `json:"
yaml:"series,
- InstanceId state.InstanceId `json:"
yaml:"instance-
- DNSName string `json:"
yaml:"dns-
- Life string `json:"
yaml:"life,
- AgentVersion string `json:"
yaml:"agent-
AgentState params.Status `json:"
yaml:"agent-
AgentStateInfo string `json:"
yaml:"agent-
+ AgentVersion string `json:"
yaml:"agent-
+ DNSName string `json:"
yaml:"dns-
+ InstanceId state.InstanceId `json:"
yaml:"instance-
InstanceState string `json:"
yaml:"instance-
+ Life string `json:"
yaml:"life,
+ Series string `json:"
yaml:"series,
}
// A goyaml bug means we can't declare these types
@@ -347,12 +347,12 @@
type serviceStatus struct { life,omitempty" omitempty" ` unitStatus `json:" units,omitempty " omitempty" ` life,omitempty" omitempty" ` relations, omitempty" ,omitempty" ` subordinate- to,omitempty" te-to,omitempty "` unitStatus `json:" units,omitempty " omitempty" ` Marshal serviceStatus
Err error `json:"-" yaml:",omitempty"`
- Life string `json:"
yaml:"life,
Charm string `json:"charm" yaml:"charm"`
Exposed bool `json:"exposed" yaml:"exposed"`
- Units map[string]
yaml:"units,
+ Life string `json:"
yaml:"life,
Relations map[string][]string `json:"
yaml:"relations
SubordinateTo []string `json:"
yaml:"subordina
+ Units map[string]
yaml:"units,
}
type serviceStatusNo
@@ -374,12 +374,12 @@
type unitStatus struct {
Err error ...