Merge lp://staging/~freyes/openstack-charm-testing/fix-post-deploy into lp://staging/openstack-charm-testing
Proposed by
Felipe Reyes
| Status: | Rejected | ||||
|---|---|---|---|---|---|
| Rejected by: | Ryan Beisner | ||||
| Proposed branch: | lp://staging/~freyes/openstack-charm-testing/fix-post-deploy | ||||
| Merge into: | lp://staging/openstack-charm-testing | ||||
| Diff against target: |
25 lines (+8/-3) 1 file modified
bin/post-deploy-config (+8/-3) |
||||
| To merge this branch: | bzr merge lp://staging/~freyes/openstack-charm-testing/fix-post-deploy | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ryan Beisner | Needs Information | ||
|
Review via email:
|
|||
Description of the change
This patch makes post-deploy-config compatible with juju 1.x and 2.x
The changes made are:
* Use 'juju status --format=yaml'
* if juju 1.x then use 'juju set', and for 2.x use 'juju set-config'
To post a comment you must log in.
Revision history for this message
| Felipe Reyes (freyes) wrote | # |
Revision history for this message
| Ryan Beisner (1chb1n) wrote | # |
Unmerged revisions
- 238. By Felipe Reyes
-
Make post-deploy-config work with juju 1.x and 2.x
* Use 'juju status --format=yaml'
* if juju 1.x then use 'juju set', and for 2.x use 'juju set-config'Fixes LP: #1616124
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thank you for your work here. However, I believe the LP bug was addressed separately and already committed. In order to consider this merge proposal, it will need to be rebased with lp:openstack-charm-testing trunk.