Merge lp://staging/~freyes/openstack-charm-testing/fix-port_security3 into lp://staging/openstack-charm-testing

Proposed by Felipe Reyes
Status: Merged
Merged at revision: 303
Proposed branch: lp://staging/~freyes/openstack-charm-testing/fix-port_security3
Merge into: lp://staging/openstack-charm-testing
Diff against target: 27 lines (+7/-1)
1 file modified
bin/post-deploy-config (+7/-1)
To merge this branch: bzr merge lp://staging/~freyes/openstack-charm-testing/fix-port_security3
Reviewer Review Type Date Requested Status
Billy Olsen Approve
OpenStack Charm Testing Maintainers Pending
Review via email: mp+328853@code.staging.launchpad.net

Description of the change

Usage of thi post-deploy-config in a cloud without port-security enabled

WITHOUT the patch:
ubuntu@freyes-bastion:~/oct⟫ ./bin/post-deploy-config neutron-gateway
Using default network name: freyes_admin_net
Configuring interface for instance deda392c-46a2-4b8e-9e16-ecfce795c010
Attaching interface to instance deda392c-46a2-4b8e-9e16-ecfce795c010
Traceback (most recent call last):
  File "./bin/post-deploy-config", line 136, in <module>
    result = neutron.create_port(body=new_port)
  File "/usr/lib/python3/dist-packages/neutronclient/v2_0/client.py", line 97, in with_params
    ret = self.function(instance, *args, **kwargs)
  File "/usr/lib/python3/dist-packages/neutronclient/v2_0/client.py", line 654, in create_port
    return self.post(self.ports_path, body=body)
  File "/usr/lib/python3/dist-packages/neutronclient/v2_0/client.py", line 363, in post
    headers=headers, params=params)
  File "/usr/lib/python3/dist-packages/neutronclient/v2_0/client.py", line 298, in do_request
    self._handle_fault_response(status_code, replybody, resp)
  File "/usr/lib/python3/dist-packages/neutronclient/v2_0/client.py", line 273, in _handle_fault_response
    exception_handler_v20(status_code, error_body)
  File "/usr/lib/python3/dist-packages/neutronclient/v2_0/client.py", line 84, in exception_handler_v20
    request_ids=request_ids)
neutronclient.common.exceptions.BadRequest: Unrecognized attribute(s) 'port_security_enabled'
Neutron server returns request_ids: ['req-81b349f1-96d8-49e7-9157-bdae57616e4f']

WITH the patch:

ubuntu@freyes-bastion:~/fix-port_security3⟫ ./bin/post-deploy-config neutron-gateway
Using default network name: freyes_admin_net
Configuring interface for instance e39858fe-3bb0-409c-a87f-a040a305cdec
Attaching interface to instance e39858fe-3bb0-409c-a87f-a040a305cdec
Configuring interface for instance deda392c-46a2-4b8e-9e16-ecfce795c010
Attaching interface to instance deda392c-46a2-4b8e-9e16-ecfce795c010
Setting data-port configuration on neutron-gateway to br-ex:fa:16:3e:79:f7:62 br-ex:fa:16:3e:75:d8:be

To post a comment you must log in.
Revision history for this message
Billy Olsen (billy-olsen) wrote :

LGTM - thanks Felipe!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: