Merge lp://staging/~freyes/openstack-charm-testing/fix-port_security into lp://staging/openstack-charm-testing
Proposed by
Felipe Reyes
Status: | Rejected |
---|---|
Rejected by: | Ryan Beisner |
Proposed branch: | lp://staging/~freyes/openstack-charm-testing/fix-port_security |
Merge into: | lp://staging/openstack-charm-testing |
Diff against target: |
41 lines (+15/-8) 1 file modified
bin/post-deploy-config (+15/-8) |
To merge this branch: | bzr merge lp://staging/~freyes/openstack-charm-testing/fix-port_security |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ryan Beisner | Needs Resubmitting | ||
Billy Olsen | Needs Fixing | ||
Review via email: mp+327049@code.staging.launchpad.net |
Description of the change
Support underclouds where port_security extension is disabled
Some clouds may have the port_security ml2 extension disabled, in those envs
at port creation the port_security_
To post a comment you must log in.
Unmerged revisions
- 300. By Felipe Reyes
-
Support underclouds where port_security extension is disabled
Some clouds may have the port_security ml2 extension disabled, in those envs
at port creation the port_security_enabled property shouldn't be passed.
Per our conversation in IRC, its probably better to have the cloud declare its capabilities and the code take that into account.