Merge lp://staging/~freyes/openstack-charm-testing/fix-port_security into lp://staging/openstack-charm-testing

Proposed by Felipe Reyes
Status: Rejected
Rejected by: Ryan Beisner
Proposed branch: lp://staging/~freyes/openstack-charm-testing/fix-port_security
Merge into: lp://staging/openstack-charm-testing
Diff against target: 41 lines (+15/-8)
1 file modified
bin/post-deploy-config (+15/-8)
To merge this branch: bzr merge lp://staging/~freyes/openstack-charm-testing/fix-port_security
Reviewer Review Type Date Requested Status
Ryan Beisner Needs Resubmitting
Billy Olsen Needs Fixing
Review via email: mp+327049@code.staging.launchpad.net

Description of the change

Support underclouds where port_security extension is disabled

Some clouds may have the port_security ml2 extension disabled, in those envs
at port creation the port_security_enabled property shouldn't be passed.

To post a comment you must log in.
Revision history for this message
Billy Olsen (billy-olsen) wrote :

Per our conversation in IRC, its probably better to have the cloud declare its capabilities and the code take that into account.

review: Needs Fixing
Revision history for this message
David Coronel (davecore) wrote :

In my stsstack, this code failed with:

Traceback (most recent call last):
  File "./bin/post-deploy-config", line 160, in <module>
    del new_port['port_security_enabled']
KeyError: 'port_security_enabled'

(full pastebin https://pastebin.canonical.com/193011/)

I commented out two lines:

"port_security_enabled": False,
del new_port['port_security_enabled']

And the script went through successfully.

Revision history for this message
Billy Olsen (billy-olsen) wrote :

davecore - yeah that's a good point. The del line should be:

del new_port['port']['port_security_enabled']

However, I think with the changes that Felipe and I discussed it would add the port_security_enabled flag to the port properties if the under-cloud's profile states it supports it.

Revision history for this message
Ryan Beisner (1chb1n) wrote :

The code repo for this project is now at the following location:
https://github.com/openstack-charmers/openstack-charm-testing

review: Needs Resubmitting

Unmerged revisions

300. By Felipe Reyes

Support underclouds where port_security extension is disabled

Some clouds may have the port_security ml2 extension disabled, in those envs
at port creation the port_security_enabled property shouldn't be passed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: