Merge lp://staging/~freyes/maas-deployer/next-py3 into lp://staging/~maas-deployers/maas-deployer/next
Proposed by
Felipe Reyes
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 76 | ||||
| Proposed branch: | lp://staging/~freyes/maas-deployer/next-py3 | ||||
| Merge into: | lp://staging/~maas-deployers/maas-deployer/next | ||||
| Diff against target: |
294 lines (+55/-29) 12 files modified
maas_deployer/cli.py (+1/-1) maas_deployer/tests/maasclient/test_bootimages.py (+2/-2) maas_deployer/tests/test_utils.py (+1/-1) maas_deployer/vmaas/engine.py (+6/-4) maas_deployer/vmaas/maasclient/apidriver.py (+4/-1) maas_deployer/vmaas/maasclient/bootimages.py (+9/-4) maas_deployer/vmaas/maasclient/clidriver.py (+4/-1) maas_deployer/vmaas/util.py (+15/-10) maas_deployer/vmaas/vm.py (+1/-1) requirements.txt (+2/-1) test-requirements.txt (+1/-0) tox.ini (+9/-3) |
||||
| To merge this branch: | bzr merge lp://staging/~freyes/maas-deployer/next-py3 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Billy Olsen | Approve | ||
|
Review via email:
|
|||
Description of the change
Hello,
This is a patch to enable maas-deployer to run in Python3, I successfully created a maas + bootstrap nodes using this patch in Xenial, this DOES NOT enable maas-deployer to deploy Xenial nodes, just to run the 'client' portion of this.
Also adds the venv target in tox, just to run maas-deployer withouth installing it (tox -e venv -- maas-deployer -c foo.yaml).
I haven't checked yet if I broke python2.7 support, as I have no trusty boxes around, so please hold on from merging it until we have verified that trusty is still working.
Best,
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM, thanks! I've been using it for a bit to test, I should have merged it sooner.