Merge lp://staging/~freyes/charms/trusty/nfs/lp1433036 into lp://staging/charms/trusty/nfs

Proposed by Felipe Reyes
Status: Work in progress
Proposed branch: lp://staging/~freyes/charms/trusty/nfs/lp1433036
Merge into: lp://staging/charms/trusty/nfs
Diff against target: 93 lines (+42/-9)
3 files modified
hooks/install (+4/-0)
tests/100-deploy (+14/-9)
tests/200-basic (+24/-0)
To merge this branch: bzr merge lp://staging/~freyes/charms/trusty/nfs/lp1433036
Reviewer Review Type Date Requested Status
Andrew McLeod (community) Needs Fixing
Review Queue (community) automated testing Needs Fixing
charmers Pending
Review via email: mp+280365@code.staging.launchpad.net

Description of the change

Dear Maintainer,

This proposal aims to fix bug #1433036, this is done adding a dummy export in the install hook, this will allow nfs-kernel-server start cleanly.

Also this patch fixes tests/100-deploy which exercises precise, for Trusty a new amulet test is added (tests/200-basic), this justs make sure that bug #1433036 is fixed.

Best,

To post a comment you must log in.
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/1855/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/1835/

review: Needs Fixing (automated testing)
Revision history for this message
Felipe Reyes (freyes) wrote :

> This item has failed automated testing! Results available here http://juju-
> ci.vapour.ws:8080/job/charm-bundle-test-lxc/1855/

This test is expected to fail when using LXC and the host is trusty, because the precise container won't be able to start the nfs server as can be seen here:

ubuntu@freyes-lxc-machine-1:~$ sudo service nfs-kernel-server restart
 * Stopping NFS kernel daemon [ OK ]
 * Unexporting directories for NFS kernel daemon... [ OK ]
FATAL: Could not load /lib/modules/3.19.0-30-generic/modules.dep: No such file or directory
 * Not starting NFS kernel daemon: no support in current kernel.
ubuntu@freyes-lxc-machine-1:~$ ls /lib/mod
modprobe.d/ modules/
ubuntu@freyes-lxc-machine-1:~$ ls /lib/modules/3.2.0-97-virtual/^C
ubuntu@freyes-lxc-machine-1:~$ uname -a
Linux freyes-lxc-machine-1 3.19.0-30-generic #34-Ubuntu SMP Fri Oct 2 22:08:41 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

Do you want me to modify the test to not use precise?, considering that this approach needs changes to not use owncloud (I think is broken or totally different for trusty, not sure) another MP is probably better

Revision history for this message
Felipe Reyes (freyes) wrote :

> This item has failed automated testing! Results available here http://juju-
> ci.vapour.ws:8080/job/charm-bundle-test-aws/1835/

I ran this test suite against AWS and I had no errors:

$ bundletester -e amazon -v
INFO:root:Bootstrapping Juju Environment...
INFO:deployer.env:bootstrapping, this might take a while...
INFO:deployer.env: Bootstrap complete
nfs
    charm-proof PASS
    00-setup PASS
    100-deploy PASS
INFO:deployer.env: Waiting for machine termination
    200-basic PASS

PASS: 4 Total: 4 (660.583451 sec)

Revision history for this message
Andrew McLeod (admcleod) wrote :

I first tried to run bundletester on this and had a relation-hook fail in owncloud, so I attempted to install it manually (cs:precise/owncloud, which deploys a later revision than specified in 100-deploy), which, FYI, fails due to package issues:

unit-owncloud-3[3717]: 2016-01-14 16:18:00 INFO unit.owncloud/3.install logger.go:40 owncloud : Depends: owncloud-server (= 8.1.5-12.1) but it is not going to be installed
unit-owncloud-3[3717]: 2016-01-14 16:18:00 INFO unit.owncloud/3.install logger.go:40 Recommends: owncloud-config-apache (= 8.1.5-12.1) but it is not going to be installed

Anyway, manually deploying revision 8 works, but I still have this issue:

0.shared-fs-relation-changed logger.go:40 /var/lib/juju/agents/unit-owncloud-0/charm/hooks/shared-fs-relation-changed: line 55: [: missing `]

Is this perhaps something to do with the revision? Can you confirm its all still working for you? (My tests were run on AWS)

review: Needs Fixing

Unmerged revisions

20. By Felipe Reyes

Add a dummy export to allow nfsd start

Fix LP: #1433036

19. By Felipe Reyes

Fix 100-deploy functional test

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: