Juju Charms Collection
memcached package

Merge lp://staging/~freyes/charms/trusty/memcached/lp1525026 into lp://staging/charms/trusty/memcached

  1. Trusty Tahr (14.04)
  2. lp1525026
  3. Merge into trunk
Proposed by Felipe Reyes
Status: Superseded
Proposed branch: lp://staging/~freyes/charms/trusty/memcached/lp1525026
Merge into: lp://staging/charms/trusty/memcached
Diff against target: 82 lines (+18/-8)
2 files modified
tests/10_deploy_test.py (+6/-3)
tests/20_deploy_replication_test.py (+12/-5)
To merge this branch: bzr merge lp://staging/~freyes/charms/trusty/memcached/lp1525026
Reviewer Review Type Date Requested Status
Review Queue (community) automated testing Needs Fixing
Adam Israel (community) Needs Fixing
charmers Pending
Review via email: mp+281254@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2016-02-25.

Description of the change

Open firewall to allow non-related machines to connect

memcached charm by default secures their units with ufw, this is intended to
avoid non-related units connect to memcached, because it's a security risk.

This patch makes sure that unit testing scripts have the ability to connect
to memcached, after it's verified that the testing script couldn't connect
the memcached port is open running (ufw insert 1 allow PORT)

make functional_test -> http://paste.ubuntu.com/14143642/

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #15824 memcached for freyes mp281254
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/15824/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #14769 memcached for freyes mp281254
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/14769/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #8386 memcached for freyes mp281254
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/8386/

Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/1921/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/1901/

review: Needs Fixing (automated testing)
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #16581 memcached for freyes mp281254
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/16581/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #15483 memcached for freyes mp281254
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/15483/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #8507 memcached for freyes mp281254
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/8507/

Revision history for this message
Felipe Reyes (freyes) wrote :

On Sat, 26 Dec 2015 14:39:31 -0000
Review Queue <email address hidden> wrote:

> Review: Needs Fixing automated testing
>
> This item has failed automated testing! Results available here
> http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/1921/

Sadly the logs aren't available anymore, but running locally I got no
errors for LXC

$ bundletester -e lxc
memcached
    charm-proof PASS
    make lint PASS
    make test PASS
    00_setup.sh PASS
    10_deploy_test.py PASS
INFO:deployer.env: Waiting for machine termination
    20_deploy_replication_test.py PASS

PASS: 6 Total: 6 (549.816231 sec)

--
Felipe Reyes
Software Sustaining Engineer @ Canonical
STS Engineering Team
# Email: <email address hidden> (GPG:0x9B1FFF39)
# Phone: +56 9 7640 7887
# Launchpad: ~freyes | IRC: freyes

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

I've requeued the tests

On Tue, Jan 5, 2016 at 2:27 PM Felipe Reyes <email address hidden>
wrote:

> On Sat, 26 Dec 2015 14:39:31 -0000
> Review Queue <email address hidden> wrote:
>
> > Review: Needs Fixing automated testing
> >
> > This item has failed automated testing! Results available here
> > http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/1921/
>
> Sadly the logs aren't available anymore, but running locally I got no
> errors for LXC
>
> $ bundletester -e lxc
> memcached
> charm-proof
> PASS
> make lint
> PASS
> make test
> PASS
> 00_setup.sh
> PASS
> 10_deploy_test.py
> PASS
> INFO:deployer.env: Waiting for machine termination
> 20_deploy_replication_test.py
> PASS
>
> PASS: 6 Total: 6 (549.816231 sec)
>
>
> --
> Felipe Reyes
> Software Sustaining Engineer @ Canonical
> STS Engineering Team
> # Email: <email address hidden> (GPG:0x9B1FFF39)
> # Phone: +56 9 7640 7887
> # Launchpad: ~freyes | IRC: freyes
>
>
> https://code.launchpad.net/~freyes/charms/trusty/memcached/lp1525026/+merge/281254
> You are reviewing the proposed merge of
> lp:~freyes/charms/trusty/memcached/lp1525026 into
> lp:charms/trusty/memcached.
>

Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/2079/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/2059/

review: Needs Fixing (automated testing)
Revision history for this message
Adam Israel (aisrael) wrote :

I ran fresh tests on LXC and Amazon yesterday, and both failed.

I think I fixed the tests on LXC (it works locally for me now), by setting allow-ufw-ip6-softfail = True and removing what looked like a duplicate line calling d.sentry['memcached/0']

https://code.launchpad.net/~aisrael/charms/trusty/memcached/charm-review-fixes

Tests are still failing on Amazon, unfortunately. Here's the bundletester output; I added some extra output in the failure to illustrate what's happening:

http://pastebin.ubuntu.com/14688975/

It looks like it's comparing a private against a public address.

Please let me know if you need any other information or you'd like me to retest.

review: Needs Fixing
Revision history for this message
Review Queue (review-queue) wrote :

The results (PASS) are in and available here: http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/2208/

review: Approve (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/2188/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/2363/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/2341/

review: Needs Fixing (automated testing)
lp://staging/~freyes/charms/trusty/memcached/lp1525026 updated
72. By Felipe Reyes

Get private-address using 'juju run'

UnitSentry doesn't populate the 'info' dict with the private-address, so
to check if the replication was properly configured in clouds where
private-address is different from the public-address, the former is retrieved
with 'juju run ... unit-get private-address'

Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/2450/

review: Needs Fixing (automated testing)

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches