Juju Charms Collection
hacluster package

Merge lp://staging/~freyes/charms/trusty/hacluster/add-location into lp://staging/~openstack-charmers/charms/trusty/hacluster/next

  1. Trusty Tahr (14.04)
  2. add-location
  3. Merge into next
Proposed by Felipe Reyes
Status: Merged
Merged at revision: 42
Proposed branch: lp://staging/~freyes/charms/trusty/hacluster/add-location
Merge into: lp://staging/~openstack-charmers/charms/trusty/hacluster/next
Diff against target: 200 lines (+108/-7)
4 files modified
.bzrignore (+1/-0)
hooks/hooks.py (+17/-7)
setup.cfg (+6/-0)
unit_tests/test_hacluster_hooks.py (+84/-0)
To merge this branch: bzr merge lp://staging/~freyes/charms/trusty/hacluster/add-location
Reviewer Review Type Date Requested Status
Jorge Niedbalski Pending
Review via email: mp+252127@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-03-06.

Description of the change

Dear OpenStack Charmers,

Add 'location' parameter to define location rules[0]. Fixes bug #1428850, and it's to fix bug #1426508

Having this consumers can define rules like "grp_percona_cluster rule inf: writable eq 1" which mean "the percona cluster vip has to be always running on a node that has the 'writable' property set to 1", in this example mysql_monitor agent will take care of check the state of percona and change the properties to reflect their actual state.

Best,

[0] http://clusterlabs.org/doc/en-US/Pacemaker/1.1-crmsh/html/Clusters_from_Scratch/_specifying_a_preferred_location.html

To post a comment you must log in.
Revision history for this message
Jorge Niedbalski (niedbalski) wrote : Posted in a previous version of this proposal

Felipe,

Thanks for this patch. Mind to add a test for covering your change?

review: Needs Fixing
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #2488 hacluster-next for freyes mp252022
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/2488/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #2278 hacluster-next for freyes mp252022
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/2278/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #2360 hacluster-next for freyes mp252022
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/10543782/
Build: http://10.245.162.77:8080/job/charm_amulet_test/2360/

Revision history for this message
Felipe Reyes (freyes) wrote : Posted in a previous version of this proposal

@niedbalski, added a unit test as suggested :) thanks to it the coverage went from 23% to 51%, so thanks for encourage me to add it.

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #2492 hacluster-next for freyes mp252127
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/2492/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #2364 hacluster-next for freyes mp252127
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/10553671/
Build: http://10.245.162.77:8080/job/charm_amulet_test/2364/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #2282 hacluster-next for freyes mp252127
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/2282/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches