Merge lp://staging/~freyes/charms/trusty/ceph-radosgw/lp1449279 into lp://staging/~openstack-charmers-archive/charms/trusty/ceph-radosgw/trunk

Proposed by Felipe Reyes
Status: Superseded
Proposed branch: lp://staging/~freyes/charms/trusty/ceph-radosgw/lp1449279
Merge into: lp://staging/~openstack-charmers-archive/charms/trusty/ceph-radosgw/trunk
Diff against target: 51 lines (+11/-8)
3 files modified
hooks/hooks.py (+3/-5)
unit_tests/test_hooks.py (+7/-2)
unit_tests/test_utils.py (+1/-1)
To merge this branch: bzr merge lp://staging/~freyes/charms/trusty/ceph-radosgw/lp1449279
Reviewer Review Type Date Requested Status
Edward Hope-Morley Approve
Review via email: mp+257700@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2015-04-29.

Description of the change

Dear OpenStack Charmers,

This patch makes radosgw consumes the proper ceph public IP, it fixes LP: 1449279

Thanks,

To post a comment you must log in.
Revision history for this message
Edward Hope-Morley (hopem) wrote :

This lgtm, i'm deploying it right now and will +1 if all succeeds.

Revision history for this message
Edward Hope-Morley (hopem) wrote :

LGTM +1

review: Approve
Revision history for this message
Edward Hope-Morley (hopem) wrote :

Just realised thsi was incorrectly targeted at trunk not /next so it did not update when i merged to next. I'll resbumit proposal and update manually to avoid confusion.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches