MongoDB Charm

Merge ~freyes/charm-mongodb:status-fix into ~mongodb-charmers/charm-mongodb:master

  1. Git
  2. lp:~freyes/charm-mongodb
  3. status-fix
  4. Merge into master
Proposed by Felipe Reyes
Status: Merged
Merged at revision: 8faa36725b36c34ca625ea88391420083b3a2934
Proposed branch: ~freyes/charm-mongodb:status-fix
Merge into: ~mongodb-charmers/charm-mongodb:master
Diff against target: 494 lines (+175/-36)
5 files modified
hooks/hooks.py (+121/-25)
hooks/update-status (+1/-0)
tests/base_deploy.py (+0/-2)
tests/deploy_replicaset.py (+32/-0)
unit_tests/test_hooks.py (+21/-9)
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
MongoDB Charm Maintainers Pending
Review via email: mp+345962@code.staging.launchpad.net

Description of the change

Hello,

I'm adding the missing pieces on top of Mario's branch[0] as he delegated on me this functionality, because he's not able to keep working on it.

The most relevant changes I made are:

f52c8db Add functional test to check workload status
2ef8834 Log replSetGetStatus only when status not found for self
eca7ebd update-status: check replica set status when relation is made
669bf19 Set workload status before returning in update_status()

Thanks,

[0] https://code.launchpad.net/~mariosplivalo/mongodb-charm/+git/mongodb-charm/+merge/341289

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote :

This looks good. Some comments inline, mostly trivial things to fix before landing. Adding a timeout when adding a secondary probably requires more thought, and likely best deferred until later.

Pre-approved from me, or I can rereview if you feel it is necessary.

review: Approve
Revision history for this message
Felipe Reyes (freyes) wrote :

Hi Stuart,

I addressed your comments, except some of the changes to the messages printed to the users, mostly because those were chosen by Mario and some of them align better with what we see in other charms (e.g. "Unit is ready...")

The functional tests log can be reviewed at http://paste.ubuntu.com/p/bn6hbtDw4g/

Best,

PS: I don't have merge privileges, so if you are OK with this MP would be great if you could merge it and publish the charm into the charmstore.

Revision history for this message
Stuart Bishop (stub) wrote :

Landed and released as cs:~mongodb-charmers/mongodb-6 / cs:mongodb-48

Revision history for this message
Felipe Reyes (freyes) wrote :

On Mon, May 28, 2018 at 07:32:00AM -0000, Stuart Bishop wrote:
> Landed and released as cs:~mongodb-charmers/mongodb-6 / cs:mongodb-48

thank you so much :-)

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: