Merge lp://staging/~freyes/charm-helpers/ufw-check-ipv6 into lp://staging/charm-helpers

Proposed by Felipe Reyes
Status: Merged
Merged at revision: 276
Proposed branch: lp://staging/~freyes/charm-helpers/ufw-check-ipv6
Merge into: lp://staging/charm-helpers
Diff against target: 76 lines (+58/-0)
2 files modified
charmhelpers/contrib/network/ufw.py (+11/-0)
tests/contrib/network/test_ufw.py (+47/-0)
To merge this branch: bzr merge lp://staging/~freyes/charm-helpers/ufw-check-ipv6
Reviewer Review Type Date Requested Status
Matt Bruzek Approve
Review via email: mp+245034@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Matt Bruzek (mbruzek) wrote :

+1 LGTM

I ran "make test" and got a successful run. Changes look good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches