Merge lp://staging/~freyes/charm-helpers/soft_fail into lp://staging/charm-helpers
Proposed by
Felipe Reyes
| Status: | Merged |
|---|---|
| Merged at revision: | 307 |
| Proposed branch: | lp://staging/~freyes/charm-helpers/soft_fail |
| Merge into: | lp://staging/charm-helpers |
| Diff against target: |
102 lines (+43/-6) 2 files modified
charmhelpers/contrib/network/ufw.py (+18/-5) tests/contrib/network/test_ufw.py (+25/-1) |
| To merge this branch: | bzr merge lp://staging/~freyes/charm-helpers/soft_fail |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jorge Niedbalski | Pending | ||
| charmers | Pending | ||
|
Review via email:
|
|||
Description of the change
Dear Charmers,
This patch adds a new argument in ufw.enable() to allow it to soft fail (or not) when IPv6 tables support couldn't be enabled and the host has IPv6 support.
This changes the current behavior, currently if ip6_tables couldn't be loaded silently disables ip6tables support in ufw, with this patch by default raises an exception (UFPIPv6Error).
This is needed to allow memcached charm a soft-fail configuration key that allows users to opt-in soft failures.
Thanks,
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
