Merge lp://staging/~freyes/charm-helpers/ip6_tables into lp://staging/charm-helpers

Proposed by Felipe Reyes
Status: Merged
Merged at revision: 299
Proposed branch: lp://staging/~freyes/charm-helpers/ip6_tables
Merge into: lp://staging/charm-helpers
Diff against target: 223 lines (+137/-18)
2 files modified
charmhelpers/contrib/network/ufw.py (+55/-12)
tests/contrib/network/test_ufw.py (+82/-6)
To merge this branch: bzr merge lp://staging/~freyes/charm-helpers/ip6_tables
Reviewer Review Type Date Requested Status
Jorge Niedbalski (community) Approve
Review Queue Pending
charmers Pending
Adam Israel Pending
Review via email: mp+247774@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-12-19.

Description of the change

Check if IPv6 is available, and if ip6_tables is loaded

The procedure to check IPv6 is:

* Check if /proc/sys/net/ipv6
* Check if ip6_tables modules is loaded, otherwise try to load it
* If any of the checks fails, then the machine is considered as
  'without IPv6' and support for it in ufw is disabled.

To post a comment you must log in.
Revision history for this message
Adam Israel (aisrael) wrote : Posted in a previous version of this proposal

Hey Felipe,

Thanks for fixing this so quickly! Tested and confirmed that it works for me. +1

review: Approve
Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches